mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lothar Rubusch <l.rubusch@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	eraretuya@gmail.com
Subject: Re: [PATCH v6 11/11] docs: iio: add documentation for adxl345 driver
Date: Fri, 18 Apr 2025 19:38:33 +0100	[thread overview]
Message-ID: <20250418193833.4abe05e7@jic23-huawei> (raw)
In-Reply-To: <20250414184245.100280-12-l.rubusch@gmail.com>

On Mon, 14 Apr 2025 18:42:45 +0000
Lothar Rubusch <l.rubusch@gmail.com> wrote:

> The documentation describes the ADXL345 driver, IIO interface,
> interface usage and configuration.
> 
> Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>

This probably wants updating to reflect the subtle _all_ vs _any_
definitions for the various events.

> +When **activity** and **inactivity** events are enabled, the driver automatically
> +will implement its hysteresis solution by setting link bit and autosleep bit.
> +The link bit serially links the activity and inactivity functions. On the other
> +side, the autosleep function switches the sensor to sleep mode if the
> +inactivity function is enabled. This will reduce current consumption to the
> +sub-12.5Hz rate. Inactivity time can be configured between 1s and 255s. When 0
> +is configured as inactivity time, the driver will define a reasonable value
> +depending on a heuristic approach to optimize power consumption.

> +A **free fall** event will be detected if the signal goes below the configured
> +threshold, for the configured time [us].
> +
Also the examples later in the document will change with the introduction of
a pseudo channel for freefall (where there is only one set of parameters for
all channels). For activity / inactivity the per channel enables mean we keep
those on the individual channels.  It's always a bit odd to report an event
for a compound channel that doesn't have it to enable, but we've never found
a better way to handle that.

Jonathan

      reply	other threads:[~2025-04-18 18:38 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14 18:42 [PATCH v6 00/11] iio: accel: adxl345: add interrupt based sensor events Lothar Rubusch
2025-04-14 18:42 ` [PATCH v6 01/11] iio: accel: adxl345: introduce adxl345_push_event function Lothar Rubusch
2025-04-14 18:42 ` [PATCH v6 02/11] iio: accel: adxl345: add single tap feature Lothar Rubusch
2025-04-14 18:42 ` [PATCH v6 03/11] iio: accel: adxl345: add double " Lothar Rubusch
2025-04-14 18:42 ` [PATCH v6 04/11] iio: accel: adxl345: set the tap suppress bit permanently Lothar Rubusch
2025-04-18 18:14   ` Jonathan Cameron
2025-04-14 18:42 ` [PATCH v6 05/11] iio: accel: adxl345: add freefall feature Lothar Rubusch
2025-04-18 18:22   ` Jonathan Cameron
2025-04-20 21:26     ` Lothar Rubusch
2025-04-21 10:16       ` Jonathan Cameron
2025-04-21 13:31         ` Lothar Rubusch
2025-04-21 13:51           ` Jonathan Cameron
2025-04-14 18:42 ` [PATCH v6 06/11] iio: accel: adxl345: extend sample frequency adjustments Lothar Rubusch
2025-04-14 18:42 ` [PATCH v6 07/11] iio: accel: adxl345: add g-range configuration Lothar Rubusch
2025-04-14 18:42 ` [PATCH v6 08/11] iio: accel: adxl345: add activity event feature Lothar Rubusch
2025-04-14 18:42 ` [PATCH v6 09/11] iio: accel: adxl345: add inactivity feature Lothar Rubusch
2025-04-18 18:34   ` Jonathan Cameron
2025-04-20 22:12     ` Lothar Rubusch
2025-04-21 10:22       ` Jonathan Cameron
2025-04-21 13:39         ` Lothar Rubusch
2025-04-21 13:54           ` Jonathan Cameron
2025-04-21 22:11             ` Lothar Rubusch
2025-04-14 18:42 ` [PATCH v6 10/11] iio: accel: adxl345: add coupling detection for activity/inactivity Lothar Rubusch
2025-04-14 18:42 ` [PATCH v6 11/11] docs: iio: add documentation for adxl345 driver Lothar Rubusch
2025-04-18 18:38   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250418193833.4abe05e7@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=eraretuya@gmail.com \
    --cc=l.rubusch@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®