From: "João Paulo Gonçalves" <jpaulo.silvagoncalves@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Watson Chow <watson.chow@avnet.com>
Cc: linux-kernel@vger.kernel.org,
"João Paulo Gonçalves" <jpaulo.silvagoncalves@gmail.com>,
stable@vger.kernel.org
Subject: [PATCH 1/2] regulator: max20086: Fix MAX200086 chip id
Date: Sun, 20 Apr 2025 15:28:01 -0300 [thread overview]
Message-ID: <20250420-fix-max20086-v1-1-8cc9ee0d5a08@gmail.com> (raw)
In-Reply-To: <20250420-fix-max20086-v1-0-8cc9ee0d5a08@gmail.com>
From MAX20086-MAX20089 datasheet, the id for a MAX20086 is 0x30 and not
0x40. With the current code, the driver will fail on probe when the
driver tries to identify the chip id from a MAX20086 device over I2C.
Cc: stable@vger.kernel.org
Fixes: bfff546aae50 ("regulator: Add MAX20086-MAX20089 driver")
Signed-off-by: João Paulo Gonçalves <jpaulo.silvagoncalves@gmail.com>
---
drivers/regulator/max20086-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/max20086-regulator.c b/drivers/regulator/max20086-regulator.c
index 59eb23d467ec058d3647d1bfb01831738bcd256c..f8081e54815d5045368a43791328b3327cf0b75f 100644
--- a/drivers/regulator/max20086-regulator.c
+++ b/drivers/regulator/max20086-regulator.c
@@ -28,7 +28,7 @@
#define MAX20086_REG_ADC4 0x09
/* DEVICE IDs */
-#define MAX20086_DEVICE_ID_MAX20086 0x40
+#define MAX20086_DEVICE_ID_MAX20086 0x30
#define MAX20086_DEVICE_ID_MAX20087 0x20
#define MAX20086_DEVICE_ID_MAX20088 0x10
#define MAX20086_DEVICE_ID_MAX20089 0x00
--
2.43.0
next prev parent reply other threads:[~2025-04-20 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-20 18:28 [PATCH 0/2] regulator: max20086: Fixes chip id and enable gpio João Paulo Gonçalves
2025-04-20 18:28 ` João Paulo Gonçalves [this message]
2025-04-20 18:28 ` [PATCH 2/2] regulator: max20086: Change enable gpio to optional João Paulo Gonçalves
2025-04-23 13:49 ` [PATCH 0/2] regulator: max20086: Fixes chip id and enable gpio Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250420-fix-max20086-v1-1-8cc9ee0d5a08@gmail.com \
--to=jpaulo.silvagoncalves@gmail.com \
--cc=broonie@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=watson.chow@avnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®