From: Tinu K Cheriya <tinuk11c@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: tinukcheriya <tinuk11c@gmail.com>
Subject: [PATCH] kvm: Improve help message clarity in dirty_log_test
Date: Mon, 21 Apr 2025 00:55:05 +0530 [thread overview]
Message-ID: <20250420192505.157018-1-tinuk11c@gmail.com> (raw)
From: tinukcheriya <tinuk11c@gmail.com>
Signed-off-by: tinukcheriya <tinuk11c@gmail.com>
---
tools/testing/selftests/kvm/dirty_log_test.c | 30 +++++++++++---------
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/tools/testing/selftests/kvm/dirty_log_test.c b/tools/testing/selftests/kvm/dirty_log_test.c
index 54da9cc20db4..ac01cf198469 100644
--- a/tools/testing/selftests/kvm/dirty_log_test.c
+++ b/tools/testing/selftests/kvm/dirty_log_test.c
@@ -503,22 +503,24 @@ static void help(char *name)
int i;
puts("");
- printf("usage: %s [-h] [-i iterations] [-I interval] "
- "[-p offset] [-m mode]\n", name);
+ printf("Usage: %s [-h] [-i iterations] [-I interval] [-p offset] [-m mode]\n", name);
puts("");
- printf(" -i: specify iteration counts (default: %"PRIu64")\n",
- TEST_HOST_LOOP_N);
- printf(" -I: specify interval in ms (default: %"PRIu64" ms)\n",
- TEST_HOST_LOOP_INTERVAL);
- printf(" -p: specify guest physical test memory offset\n"
- " Warning: a low offset can conflict with the loaded test code.\n");
- printf(" -M: specify the host logging mode "
- "(default: run all log modes). Supported modes: \n\t");
+ printf(" -i: Specify the number of test iterations (default: %"PRIu64")\n", TEST_HOST_LOOP_N);
+
+ printf(" -p: Specify the guest physical memory offset for the test.\n"
+ " Warning: Low offsets may conflict with test code loaded in memory.\n");
+ printf(" -p: Specify the guest physical memory offset for the test.\n"
+ " Warning: Low offsets may conflict with test code loaded in memory.\n");
+
+ printf(" -M: Specify the host logging mode (default: run all log modes).\n"
+ " Supported modes:\n\t");
+
log_modes_dump();
- printf(" -m: specify the guest mode ID to test "
- "(default: test all supported modes)\n"
- " This option may be used multiple times.\n"
- " Guest mode IDs:\n");
+ printf(" -m: Specify the guest mode ID to test "
+ "(default: test all supported modes).\n"
+ " You may use this option multiple times.\n"
+ " Guest mode IDs:\n");
+
for (i = 0; i < NUM_VM_MODES; ++i) {
printf(" %d: %s%s\n", i, vm_guest_mode_string(i),
guest_modes[i].supported ? " (supported)" : "");
--
2.25.1
reply other threads:[~2025-04-20 19:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250420192505.157018-1-tinuk11c@gmail.com \
--to=tinuk11c@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®