mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jinliang Zheng <alexjlzheng@gmail.com>
Cc: alexjlzheng@tencent.com, linux-kernel@vger.kernel.org, tj@kernel.org
Subject: Re: [PATCH v2 0/2] kernfs: switch global locks to per-fs lock
Date: Mon, 21 Apr 2025 08:07:18 +0200	[thread overview]
Message-ID: <2025042121-cranial-famished-c249@gregkh> (raw)
In-Reply-To: <20250420150244.127569-1-alexjlzheng@tencent.com>

On Sun, Apr 20, 2025 at 11:02:44PM +0800, Jinliang Zheng wrote:
> On Tue, 15 Apr 2025 23:36:57 +0800, Jinliang Zheng wrote:
> > From: Jinliang Zheng <alexjlzheng@tencent.com>
> > 
> > The kernfs implementation has big lock granularity so every kernfs-based
> > (e.g., sysfs, cgroup) fs are able to compete the locks. This patchset
> > switches the global locks to per-fs locks.
> > 
> > In fact, the implementation of global locks has not yet introduced
> > performance issues. But in the long run, more and more file systems will
> > be implemented based on the kernfs framework, so this optimization is
> > meaningful.
> > 
> > There are three global locks now, kernfs_idr_lock, kernfs_rename_lock
> > and kernfs_pr_cont_lock. We only switch kernfs_idr_lock and
> > kernfs_rename_lock here, because kernfs_pr_cont_lock is on a cold path.
> > 
> > Changelog:
> > v2: Only switch kernfs_idr_lock and kernfs_rename_lock to per-fs
> > v1: https://lore.kernel.org/all/20250411183109.6334-1-alexjlzheng@tencent.com/
> > 
> > Jinliang Zheng (2):
> >   kernfs: switch global kernfs_idr_lock to per-fs lock
> >   kernfs: switch global kernfs_rename_lock to per-fs lock
> > 
> >  fs/kernfs/dir.c             | 28 +++++++++++++++-------------
> >  fs/kernfs/kernfs-internal.h | 16 ++++++++++++----
> >  2 files changed, 27 insertions(+), 17 deletions(-)
> 
> Ding Dong ~

You ask this 5 days after submitting the last version, and that includes
3 of those days being a national holiday here (4 if you include today).

Please relax, I'll get to them "soon", only start to worry if it's been
more than 2 weeks.

In the meantime, to help out, please take the time to review other patch
submissions on the mailing lists.  To not do so and just expect others
to only review yours is very unbalanced.

thanks,

greg k-h

      reply	other threads:[~2025-04-21  6:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15 15:36 alexjlzheng
2025-04-15 15:36 ` [PATCH v2 1/2] kernfs: switch global kernfs_idr_lock " alexjlzheng
2025-04-15 15:36 ` [PATCH v2 2/2] kernfs: switch global kernfs_rename_lock " alexjlzheng
2025-04-20 15:02 ` [PATCH v2 0/2] kernfs: switch global locks " Jinliang Zheng
2025-04-21  6:07   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025042121-cranial-famished-c249@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=alexjlzheng@gmail.com \
    --cc=alexjlzheng@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®