From: Jiri Olsa <jolsa@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, x86@kernel.org,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"Hao Luo" <haoluo@google.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Alan Maguire" <alan.maguire@oracle.com>,
"David Laight" <David.Laight@ACULAB.COM>,
"Thomas Weißschuh" <thomas@t-8ch.de>,
"Ingo Molnar" <mingo@kernel.org>
Subject: [PATCH perf/core 02/22] uprobes: Make copy_from_page global
Date: Mon, 21 Apr 2025 23:44:02 +0200 [thread overview]
Message-ID: <20250421214423.393661-3-jolsa@kernel.org> (raw)
In-Reply-To: <20250421214423.393661-1-jolsa@kernel.org>
Making copy_from_page global and adding uprobe prefix.
Adding the uprobe prefix to copy_to_page as well for symmetry.
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
include/linux/uprobes.h | 1 +
kernel/events/uprobes.c | 10 +++++-----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
index 01112f27cd21..7447e15559b8 100644
--- a/include/linux/uprobes.h
+++ b/include/linux/uprobes.h
@@ -226,6 +226,7 @@ extern void arch_uprobe_copy_ixol(struct page *page, unsigned long vaddr,
extern void uprobe_handle_trampoline(struct pt_regs *regs);
extern void *arch_uretprobe_trampoline(unsigned long *psize);
extern unsigned long uprobe_get_trampoline_vaddr(void);
+extern void uprobe_copy_from_page(struct page *page, unsigned long vaddr, void *dst, int len);
#else /* !CONFIG_UPROBES */
struct uprobes_state {
};
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 8415c087a71f..87bca004ee6a 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -177,7 +177,7 @@ bool __weak is_trap_insn(uprobe_opcode_t *insn)
return is_swbp_insn(insn);
}
-static void copy_from_page(struct page *page, unsigned long vaddr, void *dst, int len)
+void uprobe_copy_from_page(struct page *page, unsigned long vaddr, void *dst, int len)
{
void *kaddr = kmap_atomic(page);
memcpy(dst, kaddr + (vaddr & ~PAGE_MASK), len);
@@ -205,7 +205,7 @@ static int verify_opcode(struct page *page, unsigned long vaddr, uprobe_opcode_t
* is a trap variant; uprobes always wins over any other (gdb)
* breakpoint.
*/
- copy_from_page(page, vaddr, &old_opcode, UPROBE_SWBP_INSN_SIZE);
+ uprobe_copy_from_page(page, vaddr, &old_opcode, UPROBE_SWBP_INSN_SIZE);
is_swbp = is_swbp_insn(&old_opcode);
if (is_swbp_insn(new_opcode)) {
@@ -1052,7 +1052,7 @@ static int __copy_insn(struct address_space *mapping, struct file *filp,
if (IS_ERR(page))
return PTR_ERR(page);
- copy_from_page(page, offset, insn, nbytes);
+ uprobe_copy_from_page(page, offset, insn, nbytes);
put_page(page);
return 0;
@@ -1398,7 +1398,7 @@ struct uprobe *uprobe_register(struct inode *inode,
return ERR_PTR(-EINVAL);
/*
- * This ensures that copy_from_page(), copy_to_page() and
+ * This ensures that uprobe_copy_from_page(), copy_to_page() and
* __update_ref_ctr() can't cross page boundary.
*/
if (!IS_ALIGNED(offset, UPROBE_SWBP_INSN_SIZE))
@@ -2394,7 +2394,7 @@ static int is_trap_at_addr(struct mm_struct *mm, unsigned long vaddr)
if (result < 0)
return result;
- copy_from_page(page, vaddr, &opcode, UPROBE_SWBP_INSN_SIZE);
+ uprobe_copy_from_page(page, vaddr, &opcode, UPROBE_SWBP_INSN_SIZE);
put_page(page);
out:
/* This needs to return true for any variant of the trap insn */
--
2.49.0
next prev parent reply other threads:[~2025-04-21 21:44 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 21:44 [PATCH perf/core 00/22] uprobes: Add support to optimize usdt probes on x86_64 Jiri Olsa
2025-04-21 21:44 ` [PATCH perf/core 01/22] uprobes: Rename arch_uretprobe_trampoline function Jiri Olsa
2025-04-21 21:44 ` Jiri Olsa [this message]
2025-04-21 21:44 ` [PATCH perf/core 03/22] uprobes: Move ref_ctr_offset update out of uprobe_write_opcode Jiri Olsa
2025-04-22 23:48 ` Andrii Nakryiko
2025-04-27 14:13 ` Oleg Nesterov
2025-04-28 10:51 ` Jiri Olsa
2025-04-29 13:44 ` Jiri Olsa
2025-05-06 13:11 ` Jiri Olsa
2025-05-06 14:01 ` Oleg Nesterov
2025-05-08 22:56 ` Jiri Olsa
2025-05-12 13:37 ` Oleg Nesterov
2025-04-21 21:44 ` [PATCH perf/core 04/22] uprobes: Add uprobe_write function Jiri Olsa
2025-04-21 21:44 ` [PATCH perf/core 05/22] uprobes: Add nbytes argument to uprobe_write Jiri Olsa
2025-04-22 23:48 ` Andrii Nakryiko
2025-04-21 21:44 ` [PATCH perf/core 06/22] uprobes: Add is_register argument to uprobe_write and uprobe_write_opcode Jiri Olsa
2025-04-22 23:48 ` Andrii Nakryiko
2025-04-21 21:44 ` [PATCH perf/core 07/22] uprobes: Remove breakpoint in unapply_uprobe under mmap_write_lock Jiri Olsa
2025-04-22 23:48 ` Andrii Nakryiko
2025-04-27 14:24 ` Oleg Nesterov
2025-04-28 11:11 ` Jiri Olsa
2025-04-28 11:40 ` Oleg Nesterov
2025-04-21 21:44 ` [PATCH perf/core 08/22] uprobes/x86: Add mapping for optimized uprobe trampolines Jiri Olsa
2025-04-22 23:51 ` Andrii Nakryiko
2025-04-27 14:56 ` Oleg Nesterov
2025-04-27 17:34 ` Oleg Nesterov
2025-04-28 13:48 ` Jiri Olsa
2025-04-27 18:04 ` Oleg Nesterov
2025-04-28 13:52 ` Jiri Olsa
2025-04-21 21:44 ` [PATCH perf/core 09/22] uprobes/x86: Add uprobe syscall to speed up uprobe Jiri Olsa
2025-04-22 23:48 ` Andrii Nakryiko
2025-04-27 15:51 ` Oleg Nesterov
2025-04-21 21:44 ` [PATCH perf/core 10/22] uprobes/x86: Add support to optimize uprobes Jiri Olsa
2025-04-23 0:04 ` Andrii Nakryiko
2025-04-24 12:49 ` Jiri Olsa
2025-04-24 16:06 ` Andrii Nakryiko
2025-04-27 17:11 ` Oleg Nesterov
2025-04-28 13:24 ` Jiri Olsa
2025-04-28 13:24 ` Jiri Olsa
2025-04-21 21:44 ` [PATCH perf/core 11/22] selftests/bpf: Use 5-byte nop for x86 usdt probes Jiri Olsa
2025-04-23 17:33 ` Andrii Nakryiko
2025-04-24 12:49 ` Jiri Olsa
2025-04-24 16:29 ` Andrii Nakryiko
2025-04-24 18:20 ` Andrii Nakryiko
2025-04-25 13:20 ` Jiri Olsa
2025-04-21 21:44 ` [PATCH perf/core 12/22] selftests/bpf: Reorg the uprobe_syscall test function Jiri Olsa
2025-04-23 17:34 ` Andrii Nakryiko
2025-04-21 21:44 ` [PATCH perf/core 13/22] selftests/bpf: Rename uprobe_syscall_executed prog to test_uretprobe_multi Jiri Olsa
2025-04-23 17:36 ` Andrii Nakryiko
2025-04-24 12:49 ` Jiri Olsa
2025-04-21 21:44 ` [PATCH perf/core 14/22] selftests/bpf: Add uprobe/usdt syscall tests Jiri Olsa
2025-04-23 17:40 ` Andrii Nakryiko
2025-04-24 12:49 ` Jiri Olsa
2025-04-21 21:44 ` [PATCH perf/core 15/22] selftests/bpf: Add hit/attach/detach race optimized uprobe test Jiri Olsa
2025-04-23 17:42 ` Andrii Nakryiko
2025-04-24 12:51 ` Jiri Olsa
2025-04-24 16:30 ` Andrii Nakryiko
2025-04-21 21:44 ` [PATCH perf/core 16/22] selftests/bpf: Add uprobe syscall sigill signal test Jiri Olsa
2025-04-21 21:44 ` [PATCH perf/core 17/22] selftests/bpf: Add optimized usdt variant for basic usdt test Jiri Olsa
2025-04-23 17:44 ` Andrii Nakryiko
2025-04-21 21:44 ` [PATCH perf/core 18/22] selftests/bpf: Add uprobe_regs_equal test Jiri Olsa
2025-04-23 17:46 ` Andrii Nakryiko
2025-04-24 12:51 ` Jiri Olsa
2025-04-21 21:44 ` [PATCH perf/core 19/22] selftests/bpf: Change test_uretprobe_regs_change for uprobe and uretprobe Jiri Olsa
2025-04-21 21:44 ` [PATCH perf/core 20/22] seccomp: passthrough uprobe systemcall without filtering Jiri Olsa
2025-04-21 23:04 ` Kees Cook
2025-04-21 21:44 ` [PATCH perf/core 21/22] selftests/seccomp: validate uprobe syscall passes through seccomp Jiri Olsa
2025-04-21 23:04 ` Kees Cook
2025-04-21 21:44 ` [PATCH 22/22] man2: Add uprobe syscall page Jiri Olsa
2025-04-22 7:00 ` Alejandro Colomar
2025-04-22 14:01 ` Jiri Olsa
2025-04-22 20:45 ` Alejandro Colomar
2025-05-01 21:26 ` Alejandro Colomar
2025-05-02 8:47 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250421214423.393661-3-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=David.Laight@ACULAB.COM \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=thomas@t-8ch.de \
--cc=x86@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®