From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-0201.mail-europe.com (mail-0201.mail-europe.com [51.77.79.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85A21188CB1 for ; Wed, 23 Apr 2025 00:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=51.77.79.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745367368; cv=none; b=ZkOLxDlwJGy2wMNG+xnBOcgz+NMUfI2sFzIBoeqjfoEu4Q8reHYtwGoBM39Xh4j62h2wZw9ku4rRFyzfsWC2UwD+x2PRWi30eSzeCjMgLT8jFVv4nvooNhiEFr6ycnmxs9VOaBCys7PUoqh843LV4Yzjt7CnlLO7kU84Th2m+Vo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745367368; c=relaxed/simple; bh=ncYF7mQ18ku9avEz0s0V9Bi1M8/iFnVAJ2r7P4YLiB8=; h=Date:From:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=F4oyr3MoUqbCKVQAk/MZhjhskvMUz4cKesyY1Cxc86ZrjQntWlPxKp6m02DyiNmtl8S5pc6PGBdfoMaKx3Lno5+cZ1V6YWMTBGWe85S6riEypC0o6syfSTkKiUCclm1aogdQ5Hhgk0LuPi1jnD1eqiNPXXXy7BBV1hPINmqhALM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gianis.ca; spf=pass smtp.mailfrom=gianis.ca; dkim=pass (2048-bit key) header.d=gianis.ca header.i=@gianis.ca header.b=lJrMplmf; arc=none smtp.client-ip=51.77.79.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gianis.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gianis.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gianis.ca header.i=@gianis.ca header.b="lJrMplmf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gianis.ca; s=protonmail; t=1745367350; x=1745626550; bh=cD3P74vF51V9I6kK3R4QQw3nCNaKIo/xfLpioobLPYk=; h=Date:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=lJrMplmfS05732qQtCgU3NaSYcYm8OB5C7Gist71dZZPpAbMYqjOALUYfSxRk+K4y v4RXjEmhLMZ9D+6mW7PBgWEn/941XJcdeicOOCo/dYB7ZbbSWoHBaQSebENZTqQ3GK REpZxWtBAsfB2lVUjk3pSWgWc4m+PtHlW4hB7g3DY5nFgsRbRlVmeR1RrEd4Eo2TUU GVyiSbdAfmrrjxsYc9O3SPgljyokjXyhIrMmjhOcX+i5IYt8sDe25nm3Z+Hc18T/i9 NEHIPMpJj5CK9mxU7PJkmBYW0dMukpN8MVPZKxiyAfiw8COmMuq3uNvT54eUb0/80I eHbHfYRJkOjHw== Date: Wed, 23 Apr 2025 00:15:43 +0000 From: "Dhaval Giani (AMD)" Cc: linux-kernel@vger.kernel.org, Dhaval Giani , Gautham Shenoy , K Prateek Nayak , "Dhaval Giani (AMD)" Subject: [PATCH 2/3] sched/fair: Add a test to test that a task selected to run has positive lag Message-ID: <20250422-b4-eevdf-tests-v1-post-v1-2-5b174f040f55@gianis.ca> Feedback-ID: 128275035:user:proton X-Pm-Message-ID: c2ae51e5265d3df4c700c96a2800d4c3aff4d275 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Lemma 1 from the original EEVDF paper says that any task that has a positive lag is eligible to run. This test tests the opposite - any task that is picked to run must have a positive lag for it to be eligible to run. Signed-off-by: Dhaval Giani (AMD) --- kernel/sched/eevdf-tests.c | 41 +++++++++++++++++++++++++++++++++++++++++ kernel/sched/fair.c | 2 ++ kernel/sched/sched.h | 2 ++ 3 files changed, 45 insertions(+) diff --git a/kernel/sched/eevdf-tests.c b/kernel/sched/eevdf-tests.c index 3bc016d3025733e53f586e30fcd31f650156d47e..8532330769bcc93dbf9cd98ebba= 75c838f62c045 100644 --- a/kernel/sched/eevdf-tests.c +++ b/kernel/sched/eevdf-tests.c @@ -18,10 +18,51 @@ =20 #ifdef CONFIG_SCHED_EEVDF_TESTING =20 +/* + * Test parameters + */ +bool eevdf_positive_lag_test; +u8 eevdf_positive_lag_count =3D 10; + static struct dentry *debugfs_eevdf_testing; void debugfs_eevdf_testing_init(struct dentry *debugfs_sched) { =09debugfs_eevdf_testing =3D debugfs_create_dir("eevdf-testing", debugfs_s= ched); =20 +=09debugfs_create_bool("eevdf_positive_lag_test", 0700, +=09=09=09=09debugfs_eevdf_testing, &eevdf_positive_lag_test); +=09debugfs_create_u8("eevdf_positive_lag_test_count", 0600, +=09=09=09=09debugfs_eevdf_testing, &eevdf_positive_lag_count); + } + +void test_eevdf_positive_lag(struct cfs_rq *cfs, struct sched_entity *se) +{ +=09static int eevdf_positive_lag_test_counter; +=09u64 eevdf_average_vruntime; + +=09if (!eevdf_positive_lag_test) +=09=09return; + +=09if (!se || !cfs) +=09=09return; + +=09eevdf_average_vruntime =3D avg_vruntime(cfs); +=09eevdf_positive_lag_test_counter++; + +=09if (se->vruntime > eevdf_average_vruntime) { +=09=09trace_printk("FAIL: Lemma 1 failed - selected task has negative lag\= n"); +=09=09eevdf_positive_lag_test =3D 0; +=09=09eevdf_positive_lag_test_counter =3D 0; +=09=09return; +=09} + +=09if (eevdf_positive_lag_test_counter > eevdf_positive_lag_count) { +=09=09eevdf_positive_lag_test =3D 0; +=09=09eevdf_positive_lag_test_counter =3D 0; +=09=09trace_printk("PASS: At least %u selected tasks had positive lag\n", +=09=09=09=09=09=09=09eevdf_positive_lag_count); +=09} +} + #endif /* CONFIG_SCHED_EEVDF_TESTING */ diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index eb5a2572b4f8b6b5517befc299312b6ae7476e88..924d9d35c2aa937bc0f4ca9565b= a774397b90f77 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -980,6 +980,8 @@ static struct sched_entity *pick_eevdf(struct cfs_rq *c= fs_rq) =09if (!best || (curr && entity_before(curr, best))) =09=09best =3D curr; =20 +=09test_eevdf_positive_lag(cfs_rq, best); + =09return best; } =20 diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 09cefe2aa871bbd533a413c76026895e969a58e7..5ad5e033e1c81167b712ab176d4= d55e6b5d82d06 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -3990,8 +3990,10 @@ void sched_enq_and_set_task(struct sched_enq_and_set= _ctx *ctx); =20 #ifdef CONFIG_SCHED_EEVDF_TESTING void debugfs_eevdf_testing_init(struct dentry *debugfs_sched); +void test_eevdf_positive_lag(struct cfs_rq *cfs, struct sched_entity *se); #else /* CONFIG_SCHED_EEVDF_TESTING */ static inline void init_eevdf_testing_debugfs(struct dentry *debugfs_sched= ) {} +static inline void test_eevdf_positive_lag(struct cfs_rq *cfs, struct sche= d_entity *se) {} #endif /* CONFIG_SCHED_EEVDF_TESTING */ =20 #endif /* _KERNEL_SCHED_SCHED_H */ --=20 2.49.0