From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EADAF28A1D2 for ; Wed, 23 Apr 2025 17:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745428541; cv=none; b=dwAOgbIDxJhTmPwEAWudfI56hVlEHUpHcLlVTz3Z1vxJxPh5kQvNgyyiMuNhPT8Gkpf0EkbfnAHaw3A33D+XPRh8P1+vH7IkRyu6GZciaP4+1+TumfcM9vUPH1tGCEXTvocaREGiR4lUAToU/OTvN0Vv7PEImjWPsHj2Q3IuIeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745428541; c=relaxed/simple; bh=ZSWmIXnoHeqHpg22is4DCb+FQUxyjWQhdchI0xl2uAo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tqf00ac7tqg6A1JztbHOCyp8DYkyFcIxGe0Bpb5+jVNEj6PGih1SE85TBOR++lRxYTAGowYWa3EYano2c+VpYs2qjSGKTx7P9qGvEeCXqZs2Hda6AXrwbmxvNQknBPbf/ryXp7bAs4ttwpeLtCMDc599Qv3/BB2pUR3beMascLk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=f3RJOF+9; arc=none smtp.client-ip=209.85.222.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="f3RJOF+9" Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-86cce5dac90so71142241.0 for ; Wed, 23 Apr 2025 10:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1745428539; x=1746033339; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sAA3ahIS+2Nb+9ARKVTXCSjk2uwR/TOFzjA5DEQnqxg=; b=f3RJOF+9I5aUeLfKwhY41cyNNsV/7gzE8mnt0B7y7vbeRVxS8lsyPkRNroBYBI3tAJ LoOcUnWESA/cjHCPlWjRHA3M+53oDTrejya0NpMfeL6ljH+lfqQ/w5WsXx5ptqIdwRDv nsp4EdSeE1qB0xl7OhzzYJKM36aE0m+MI2XLpfk6xpvXrCfNBJoewKHE7+njIVYSVVE9 uh237S2zCPLxHmND8hCSoBynFpTclSrt0aPYz/VfLhJATgS9agmNsggyOtAJAI5FOQCt Odf2Xxn7vp+XAbxZin8Yl6xswoHmQ5A7Db9GS23ti5naaSYjMpciujFTq8n0nXWju1+8 8EaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745428539; x=1746033339; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sAA3ahIS+2Nb+9ARKVTXCSjk2uwR/TOFzjA5DEQnqxg=; b=NWZUYF/cDfFo+2dRNy88ZtsEU68azNn48MOWGWpoQpN0rqC3thqtPVbW/DeLtPh/EW ltEk38IvY4CgB+6UGnt4G/kcisa7Xecw7UVfbhxTCr6bNaU4ivajmGdEnjQtw1XcAwZs pkMrqPaAMk9SFHutssjYD3zBkLoxPnd5iH2IWtHCdnV++bU4tsfSsXQ3II7z6kPXMwdk tdeF6yOyYnq7W5vuM40otnLWd2Ykc/f5LjZpvTKZp0sb/LwaFc2DzVinM7xlKwT7znQl 7StrHaDqhIO9O4iXwwZmLhwaTY6ufgYY5AbEDNenl1BRGThUS1uStSkC4RVj6/8ZW1tr Kzjg== X-Forwarded-Encrypted: i=1; AJvYcCXlLmLaZoxg8LAVFoFMuNcUDxWDLINqKN1NVACVxIYAdEtyLOY7Rl9i1jWLSir8gcvSVLk296t8rmDXzuo=@vger.kernel.org X-Gm-Message-State: AOJu0YxNEmhGZSpAuov+eC2oBZyMngZweRE6hH2XFgkMHSGNIskaPBss Dam1lq3xBMbLG6mp1gjltNxVd1MEl4L8rGY2FU8s5kk0gXGiGx4BQMSAW+QyPIU= X-Gm-Gg: ASbGnctr37EXbnVOHFIwWx1iQdicn+pklsecVwVbvA0s0xBuuioDDyOHy4JRsKWp3fm vNk0ujJA9UpYEdfXjQ+qqdnK/ZPlBQWFM72AtrkFtInrJFxhuHqhm7Gwi8Eeh3I7pbmGXXCDI0s ztqwTh1o+MhZ0vVyMCO7ZCCAPCF19ymN89NHCBv90xi6YATekUcKZGUqVVzyud2mZJmEkcqrygE 08unyO63x0TnPoraKjExcfn8DSZ5lKbN/Az/YAYI1Fv6DtesJDBsFxgRlLX7hn9ch7Fg9pYWiro nFzjiiD5Nt0VHGPvwJr/r78mt8RpecadLeMGJOXUv8dAtmHl+ZQVZiBNjW4Rmw8t/V8jlDcFLtS siruecPMmH990K/F3OvRCIODqKGd+sg== X-Google-Smtp-Source: AGHT+IG91ka296h4XrJ4QPDo73jdYlZoOj1Zkc9PInMILwbVuqXEZMd5w4C/WgEttaatAxBubBvu3Q== X-Received: by 2002:a05:6122:3c54:b0:529:24f8:dbdd with SMTP id 71dfb90a1353d-529253da601mr17813854e0c.4.1745428538734; Wed, 23 Apr 2025 10:15:38 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-219-86.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.219.86]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-52a74d3a2d0sm79186e0c.40.2025.04.23.10.15.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 10:15:38 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1u7dhB-00000007LQW-2UhV; Wed, 23 Apr 2025 14:15:37 -0300 Date: Wed, 23 Apr 2025 14:15:37 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch , Jake Edge , Jonathan Corbet , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni , Leon Romanovsky Subject: Re: [PATCH v9 03/24] iommu: generalize the batched sync after map interface Message-ID: <20250423171537.GJ1213339@ziepe.ca> References: <2ce6a74ddf5e13a7fdb731984aa781a15f17749d.1745394536.git.leon@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ce6a74ddf5e13a7fdb731984aa781a15f17749d.1745394536.git.leon@kernel.org> On Wed, Apr 23, 2025 at 11:12:54AM +0300, Leon Romanovsky wrote: > From: Christoph Hellwig > > For the upcoming IOVA-based DMA API we want to use the interface batch the > sync after mapping multiple entries from dma-iommu without having a > scatterlist. Grammer: For the upcoming IOVA-based DMA API we want to batch the ops->iotlb_sync_map() call after mapping multiple IOVAs from dma-iommu without having a scatterlist. Improve the API. Add a wrapper for the map_sync as iommu_sync_map() so that callers don't need to poke into the methods directly. Formalize __iommu_map() into iommu_map_nosync() which requires the caller to call iommu_sync_map() after all maps are completed. Refactor the existing sanity checks from all the different layers into iommu_map_nosync(). > drivers/iommu/iommu.c | 65 +++++++++++++++++++------------------------ > include/linux/iommu.h | 4 +++ > 2 files changed, 33 insertions(+), 36 deletions(-) Reviewed-by: Jason Gunthorpe > + /* Discourage passing strange GFP flags */ > + if (WARN_ON_ONCE(gfp & (__GFP_COMP | __GFP_DMA | __GFP_DMA32 | > + __GFP_HIGHMEM))) > + return -EINVAL; There is some kind of overlap with the new iommu_alloc_pages_node() here that does a similar check, nothing that can be addressed in this series but maybe a TBD for later.. Jason