From: Prabhav Kumar Vaish <pvkumar5749404@gmail.com>
To: martin.lau@linux.dev
Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
daniel@iogearbox.net, eddyz87@gmail.com, haoluo@google.com,
john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
mykolal@fb.com, pvkumar5749404@gmail.com, sdf@fomichev.me,
shuah@kernel.org, song@kernel.org, yonghong.song@linux.dev
Subject: Re: [PATCH] selftests/bpf: Fix potential null pointer dereference in skb_pkt_end.c
Date: Wed, 23 Apr 2025 23:28:14 +0530 [thread overview]
Message-ID: <20250423175814.1273032-1-pvkumar5749404@gmail.com> (raw)
In-Reply-To: <e7ee365f-f275-4ee0-80fb-370cb3c242ea@linux.dev>
From: Prabhav Kumar <pvkumar5749404@gmail.com>
Hi Martin,
Thank you for the feedback.
You're right — I reviewed commit 9cc873e85800 and now understand that the test is designed to validate specific LLVM code generation, not just runtime behavior. I see how my change, although addressing the warning, could unintentionally alter the generated instructions and defeat the purpose of the test.
I'll drop this patch to preserve the original test intent. Thanks again for the context!
Best Regards,
Prabhav
prev parent reply other threads:[~2025-04-23 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 18:23 [PATCH] selftests/bpf: Fix null pointer check " Prabhav Kumar Vaish
2025-04-22 22:15 ` Martin KaFai Lau
2025-04-23 17:58 ` Prabhav Kumar Vaish [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423175814.1273032-1-pvkumar5749404@gmail.com \
--to=pvkumar5749404@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®