From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: maddy@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
npiggin@gmail.com, christophe.leroy@csgroup.eu,
gautam@linux.ibm.com, vaibhav@linux.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] powerpc: kvm: use generic transfer to guest mode work
Date: Thu, 24 Apr 2025 16:42:15 +0200 [thread overview]
Message-ID: <20250424144215._ooDjDz9@linutronix.de> (raw)
In-Reply-To: <20250421102837.78515-2-sshegde@linux.ibm.com>
On 2025-04-21 15:58:36 [+0530], Shrikanth Hegde wrote:
> diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
> index 19f4d298d..123539642 100644
> --- a/arch/powerpc/kvm/book3s_hv.c
> +++ b/arch/powerpc/kvm/book3s_hv.c
> @@ -80,8 +80,8 @@
> #include <asm/ultravisor.h>
> #include <asm/dtl.h>
> #include <asm/plpar_wrappers.h>
> -
> #include <trace/events/ipi.h>
> +#include <linux/entry-kvm.h>
>
> #include "book3s.h"
> #include "book3s_hv.h"
> @@ -4901,7 +4901,7 @@ int kvmhv_run_single_vcpu(struct kvm_vcpu *vcpu, u64 time_limit,
> }
>
> if (need_resched())
> - cond_resched();
> + schedule();
This looks unrelated and odd. I don't why but this should be a
cond_resched() so it can be optimized away on PREEMPT kernels.
> kvmppc_update_vpas(vcpu);
>
> @@ -5097,10 +5097,11 @@ static int kvmppc_vcpu_run_hv(struct kvm_vcpu *vcpu)
> return -EINVAL;
> }
>
> - /* No need to go into the guest when all we'll do is come back out */
> - if (signal_pending(current)) {
> - run->exit_reason = KVM_EXIT_INTR;
> - return -EINTR;
> + /* use generic frameworks to handle signals, need_resched */
> + if (__xfer_to_guest_mode_work_pending()) {
> + r = xfer_to_guest_mode_handle_work(vcpu);
This could be unconditional.
> + if (r)
> + return r;
> }
>
> #ifdef CONFIG_PPC_TRANSACTIONAL_MEM
> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
> index 153587741..4ff334532 100644
> --- a/arch/powerpc/kvm/powerpc.c
> +++ b/arch/powerpc/kvm/powerpc.c
> @@ -34,6 +34,7 @@
> #endif
> #include <asm/ultravisor.h>
> #include <asm/setup.h>
> +#include <linux/entry-kvm.h>
>
> #include "timing.h"
> #include "../mm/mmu_decl.h"
> @@ -80,24 +81,17 @@ int kvmppc_prepare_to_enter(struct kvm_vcpu *vcpu)
> {
> int r;
>
> + /* use generic framework to handle need resched and signals */
> + if (__xfer_to_guest_mode_work_pending()) {
> + r = xfer_to_guest_mode_handle_work(vcpu);
there is nothing special you do checking and handling the work. Couldn't
you invoke xfer_to_guest_mode_handle_work() unconditionally?
> + if (r)
> + return r;
> + }
> +
> WARN_ON(irqs_disabled());
> hard_irq_disable();
>
> while (true) {
> - if (need_resched()) {
> - local_irq_enable();
> - cond_resched();
> - hard_irq_disable();
> - continue;
> - }
> -
> - if (signal_pending(current)) {
> - kvmppc_account_exit(vcpu, SIGNAL_EXITS);
> - vcpu->run->exit_reason = KVM_EXIT_INTR;
> - r = -EINTR;
> - break;
I don't how this works but couldn't SIGNAL_EXITS vanish now that it
isn't updated anymore? The stat itself moves in kvm_handle_signal_exit()
to a different counter so it is not lost. The reader just needs to look
somewhere else for it.
> - }
> -
> vcpu->mode = IN_GUEST_MODE;
>
> /*
Sebastian
next prev parent reply other threads:[~2025-04-24 14:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 10:28 [PATCH 0/2] powerpc: kvm: generic framework and run posix timers in task context Shrikanth Hegde
2025-04-21 10:28 ` [PATCH 1/2] powerpc: kvm: use generic transfer to guest mode work Shrikanth Hegde
2025-04-24 14:42 ` Sebastian Andrzej Siewior [this message]
2025-04-24 15:57 ` Shrikanth Hegde
2025-04-24 18:38 ` Sebastian Andrzej Siewior
2025-04-25 11:19 ` Shrikanth Hegde
2025-04-25 13:31 ` Sebastian Andrzej Siewior
2025-04-25 14:24 ` Shrikanth Hegde
2025-04-25 16:23 ` Sebastian Andrzej Siewior
2025-04-29 6:19 ` Shrikanth Hegde
2025-04-21 10:28 ` [PATCH 2/2] powerpc: enable to run posix cpu timers in task context Shrikanth Hegde
2025-04-21 12:34 ` [PATCH 0/2] powerpc: kvm: generic framework and run posix " Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424144215._ooDjDz9@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=christophe.leroy@csgroup.eu \
--cc=gautam@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=sshegde@linux.ibm.com \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®