From: Corey Minyard <corey@minyard.net>
To: linux-kernel@vger.kernel.org,
openipmi-developer@lists.sourceforge.net,
Rik van Riel <riel@surriel.com>
Cc: "Paul E . McKenney" <paulmck@kernel.org>,
Breno Leitao <leitao@debian.org>,
Corey Minyard <corey@minyard.net>,
Corey Minyard <cminyard@mvista.com>
Subject: [PATCH 10/23] ipmi: Add a note about the pretimeout callback
Date: Thu, 24 Apr 2025 11:49:47 -0500 [thread overview]
Message-ID: <20250424165020.627193-11-corey@minyard.net> (raw)
In-Reply-To: <20250424165020.627193-1-corey@minyard.net>
You can't do IPMI calls from the callback, it's called with locks
held.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
include/linux/ipmi.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/ipmi.h b/include/linux/ipmi.h
index 2f74dd90c271..27cd5980bb27 100644
--- a/include/linux/ipmi.h
+++ b/include/linux/ipmi.h
@@ -93,7 +93,8 @@ struct ipmi_user_hndl {
/*
* Called when the interface detects a watchdog pre-timeout. If
- * this is NULL, it will be ignored for the user.
+ * this is NULL, it will be ignored for the user. Note that you
+ * can't do any IPMI calls from here, it's called with locks held.
*/
void (*ipmi_watchdog_pretimeout)(void *handler_data);
--
2.43.0
next prev parent reply other threads:[~2025-04-24 16:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 16:49 [PATCH 00/23] ipmi: Remove SRCU and handle the fallout Corey Minyard
2025-04-24 16:49 ` [PATCH 01/23] ipmi:msghandler: Use READ_ONCE on run_to_completion Corey Minyard
2025-04-24 16:49 ` [PATCH 02/23] ipmi:msghandler: Rename recv_work to smi_work Corey Minyard
2025-04-24 16:49 ` [PATCH 03/23] ipmi:msghandler: Move timer handling into a work queue Corey Minyard
2025-04-24 16:49 ` [PATCH 04/23] ipmi:msghandler: Deliver user messages in " Corey Minyard
2025-04-24 16:49 ` [PATCH 05/23] ipmi_msghandler: Change the events lock to a mutex Corey Minyard
2025-04-24 16:49 ` [PATCH 06/23] ipmi:msghandler: Use the system_wq, not system_bh_wq Corey Minyard
2025-04-24 16:49 ` [PATCH 07/23] ipmi:msghandler: Remove srcu from the ipmi user structure Corey Minyard
2025-04-24 16:49 ` [PATCH 08/23] ipmi:msghandler: Remove srcu for the ipmi_interfaces list Corey Minyard
2025-04-24 16:49 ` [PATCH 09/23] ipmi:watchdog: Change lock to mutex Corey Minyard
2025-04-24 16:49 ` Corey Minyard [this message]
2025-04-24 16:49 ` [PATCH 11/23] ipmi:msghandler: Remove some user level processing in panic mode Corey Minyard
2025-04-24 16:49 ` [PATCH 12/23] ipmi:msghandler: Fix locking around users and interfaces Corey Minyard
2025-04-24 16:49 ` [PATCH 13/23] ipmi:msghandler: Don't acquire a user refcount for queued messages Corey Minyard
2025-04-24 16:49 ` [PATCH 14/23] ipmi:msghandler: Don't check for shutdown when returning responses Corey Minyard
2025-04-24 16:49 ` [PATCH 15/23] ipmi:msghandler: Remove proc_fs.h Corey Minyard
2025-04-24 16:49 ` [PATCH 16/23] ipmi:msghandler: Shut down lower layer first at unregister Corey Minyard
2025-04-24 16:49 ` [PATCH 17/23] ipmi:msghandler: Add a error return from unhandle LAN cmds Corey Minyard
2025-04-24 16:49 ` [PATCH 18/23] ipmi:si: Rework startup of IPMI devices Corey Minyard
2025-04-24 16:49 ` [PATCH 19/23] ipmi:msghandler: Don't deliver messages to deleted users Corey Minyard
2025-04-24 16:49 ` [PATCH 20/23] ipmi:ssif: Fix a shutdown race Corey Minyard
2025-04-24 16:49 ` [PATCH 21/23] Documentation:ipmi: Remove comments about interrupt level Corey Minyard
2025-04-24 16:49 ` [PATCH 22/23] ipmi:msghandler: Export and fix panic messaging capability Corey Minyard
2025-04-24 16:50 ` [PATCH 23/23] ipmi:watchdog: Use the new interface for panic messages Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424165020.627193-11-corey@minyard.net \
--to=corey@minyard.net \
--cc=cminyard@mvista.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=paulmck@kernel.org \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®