From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA7FA22B8D2 for ; Fri, 25 Apr 2025 07:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745567190; cv=none; b=BLWbRktT9t7dQjIOX26SOcx7w+o1boLofZcfBjVJg1j6u3veDc0qFIQlTOPhaHUkOyS30i3e3k32SwL9XCR9F7FK3fCkfxUsfpoSd4rU/ZkeNY7WhQJ9a4uaoUAtT14257iK1OoSUwiaiezmLVVvxFqoXI7yKoRKzagkk6lq9YE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745567190; c=relaxed/simple; bh=M2e5e0DbBcCkM53d/193BeEEWoXcJicJMcob4XfVxtg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fgffP41CPyx6mHXxGyvbdZnpjicR7eH/66MPyxlCSywQgagJ6e92h+Y3Hgaua1ywLOMwQPl9nPaVGe1WjbFWTzN9xjLkcEqK2OQ19IuRanU7EabbkfcabJ9jTIVZe4n4y/JGM7g9GqbaQ9YoZiTooAg47iBtcHshBaOcnECYWo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=BONzwATD; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="BONzwATD" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so18595005e9.2 for ; Fri, 25 Apr 2025 00:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1745567186; x=1746171986; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yalr6Bu93K2GzLCvN0XHCxzUAzn2mCxagWptxLA843Q=; b=BONzwATDn/a2Jbfl2U/CRNZi6nvEygafRicZHs3E01vwo9Vk0ZH7vrqo9dHe7NAp51 gS/di6U0SsI2y61hjPKlZN7hHtXGxxQCTYYAVie4dgOUhY+Q7N3WXWFsB8YN55Q9i2i2 JTzQUtB+zF67/ain39qAEr9FBYWqwsQRfg+iIHrIaZ3G2odO5yQCBtr0IUMml9EP1bDq pZpxlieYZmifYhKjSmNVmUmK+dOcxlcC/l6OdbaAssA4ntsgHsMXAk+SWpAskvjBNyul 8HHDB+GtNKM9Hs8rpxZeaAHMHyn9jyBJF3Jq+0ww5ss/Yx9ZAH3k/OAESYnYn+todGiu X7UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745567186; x=1746171986; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yalr6Bu93K2GzLCvN0XHCxzUAzn2mCxagWptxLA843Q=; b=GCMKTNXl3NlkUDdfQlmpj0BeeOZa2zJmFx5p4DW2fbSNs2fgUlYKNZmQBCiLtlcoEa 3tjfahhbnGqoghe9QElMwI5neXUCZdYsWvVtTgYdrnSctAv0mziyRMF2HIddAE5IVg0m pNN9vfR2TEUwRqIBMc5I8pqZnmwnr8YO8nSLd0YGpE2IXzA8PTSklfPeoySVwd7bRVQB IFLea8EqoVXcGKVRnQBVkYDugygeqrFvCkNBaauH9gLKZpJ7cFWkI98ocpgl5ng0e5of lf42M00Zsmr7i7C4peiwTOQl7Y33kOu9xTlSTuOvbImdLYhcnyR1bzZmuNgi/LwV+BIo C08w== X-Forwarded-Encrypted: i=1; AJvYcCUTu1cq6E/gwFvuXm64qV9OiB10HhLifeDQUQTqKvffE7rJV8Gx+5/AAkaZ3gY/HzCFt26CIyjK/whNOjM=@vger.kernel.org X-Gm-Message-State: AOJu0YyWOVJPequnfKuwUWY/S3HOHvJgvXIvpTvymfB3aETWuwjEXRra 3vXLdZ6vdx3tom3qOelAgEeKt96MdSHOanNISlwDZLFSCpLDDUVqj5dGe/3ucregMiiBZVKGDug Osvk= X-Gm-Gg: ASbGncuqV2pHD4yXcdkApnDEVOe3b3VVbstCwwS7hYPolNp1/1aUMv8WRRgNluBos59 IGHmRg+F6FD+swXDEugjYgRKb6kfUzydpCFr+HEYngxh0ctBabJHXyyj2OV8chRd/VwKfptNFVs pjWAIiEjqjbxrY0ZwfLI9n1jT7729xgFBSJ/h8l/r5vC9PF8FXwM0x1raFH+7O7vIAC0Edm3zs9 ERO4zuzW3O4gDIlg/8WaQmoEv4DKdPinYW3vAIA2eMXYKUtj38bUc6FxQsb4mEXxx8of3bKXlzE 7Gs1KIOC5H8r7ABWRSry0/VrrYwJ X-Google-Smtp-Source: AGHT+IGuKsjAp/bE7iMICTe5tl7fZLkgjjuJMOyAsBGa6hvpBqMsjN2EfsDi9JbPSKmGTEeYZJEdtA== X-Received: by 2002:a05:6000:4212:b0:38f:2ddd:a1bb with SMTP id ffacd0b85a97d-3a074e144a6mr901505f8f.8.1745567185228; Fri, 25 Apr 2025 00:46:25 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200::f716]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073e46c23sm1496676f8f.75.2025.04.25.00.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 00:46:24 -0700 (PDT) Date: Fri, 25 Apr 2025 09:46:24 +0200 From: Andrew Jones To: =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= Cc: Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org, Samuel Holland , Deepak Gupta Subject: Re: [PATCH v6 02/14] riscv: sbi: remove useless parenthesis Message-ID: <20250425-00fafd9027c5b1be3dd1d78e@orel> References: <20250424173204.1948385-1-cleger@rivosinc.com> <20250424173204.1948385-3-cleger@rivosinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250424173204.1948385-3-cleger@rivosinc.com> On Thu, Apr 24, 2025 at 07:31:49PM +0200, Clément Léger wrote: > A few parenthesis in check for SBI version/extension were useless, > remove them. > > Signed-off-by: Clément Léger > --- > arch/riscv/kernel/sbi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/riscv/kernel/sbi.c b/arch/riscv/kernel/sbi.c > index 1989b8cade1b..1d44c35305a9 100644 > --- a/arch/riscv/kernel/sbi.c > +++ b/arch/riscv/kernel/sbi.c > @@ -609,7 +609,7 @@ void __init sbi_init(void) > } else { > __sbi_rfence = __sbi_rfence_v01; > } > - if ((sbi_spec_version >= sbi_mk_version(0, 3)) && > + if (sbi_spec_version >= sbi_mk_version(0, 3) && > sbi_probe_extension(SBI_EXT_SRST)) { > pr_info("SBI SRST extension detected\n"); > pm_power_off = sbi_srst_power_off; > @@ -617,8 +617,8 @@ void __init sbi_init(void) > sbi_srst_reboot_nb.priority = 192; > register_restart_handler(&sbi_srst_reboot_nb); > } > - if ((sbi_spec_version >= sbi_mk_version(2, 0)) && > - (sbi_probe_extension(SBI_EXT_DBCN) > 0)) { > + if (sbi_spec_version >= sbi_mk_version(2, 0) && > + sbi_probe_extension(SBI_EXT_DBCN) > 0) { > pr_info("SBI DBCN extension detected\n"); > sbi_debug_console_available = true; > } > -- > 2.49.0 > Reviewed-by: Andrew Jones