From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>
Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 04/23] drm/connector: hdmi: Add missing bpc debug info to hdmi_try_format_bpc()
Date: Fri, 25 Apr 2025 13:26:55 +0300 [thread overview]
Message-ID: <20250425-hdmi-conn-yuv-v4-4-5e55e2aaa3fa@collabora.com> (raw)
In-Reply-To: <20250425-hdmi-conn-yuv-v4-0-5e55e2aaa3fa@collabora.com>
The very first debug message in hdmi_try_format_bpc() is incomplete, as
it doesn't provide the given bpc in addition to the tried format.
Add the missing debug information and drop the now redundant message
from hdmi_compute_config().
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
drivers/gpu/drm/display/drm_hdmi_state_helper.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/drm/display/drm_hdmi_state_helper.c
index a0cb3163f457635cf27e53b009bd83f85eee9336..f54eb5c594cddbd67dfacb5e06d54e9ce7851013 100644
--- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c
+++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c
@@ -578,8 +578,9 @@ hdmi_try_format_bpc(const struct drm_connector *connector,
struct drm_device *dev = connector->dev;
int ret;
- drm_dbg_kms(dev, "Trying %s output format\n",
- drm_hdmi_connector_get_output_format_name(fmt));
+ drm_dbg_kms(dev, "Trying %s output format with %u bpc\n",
+ drm_hdmi_connector_get_output_format_name(fmt),
+ bpc);
if (!sink_supports_format_bpc(connector, info, mode, fmt, bpc)) {
drm_dbg_kms(dev, "%s output format not supported with %u bpc\n",
@@ -638,8 +639,6 @@ hdmi_compute_config(const struct drm_connector *connector,
int ret;
for (bpc = max_bpc; bpc >= 8; bpc -= 2) {
- drm_dbg_kms(dev, "Trying with a %d bpc output\n", bpc);
-
ret = hdmi_compute_format(connector, conn_state, mode, bpc);
if (ret)
continue;
--
2.49.0
next prev parent reply other threads:[~2025-04-25 10:28 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 10:26 [PATCH v4 00/23] drm/connector: hdmi: Allow using the YUV420 output format Cristian Ciocaltea
2025-04-25 10:26 ` [PATCH v4 01/23] drm/connector: hdmi: Evaluate limited range after computing format Cristian Ciocaltea
2025-04-25 10:26 ` [PATCH v4 02/23] drm/connector: hdmi: Add support for YUV420 format verification Cristian Ciocaltea
2025-04-25 10:26 ` [PATCH v4 03/23] drm/connector: hdmi: Improve debug message for supported format Cristian Ciocaltea
2025-04-25 10:26 ` Cristian Ciocaltea [this message]
2025-04-25 10:26 ` [PATCH v4 05/23] drm/connector: hdmi: Factor out bpc and format computation logic Cristian Ciocaltea
2025-04-25 10:26 ` [PATCH v4 06/23] drm/connector: hdmi: Use YUV420 output format as an RGB fallback Cristian Ciocaltea
2025-05-13 13:35 ` Maxime Ripard
2025-05-15 12:44 ` Cristian Ciocaltea
2025-05-15 14:52 ` Maxime Ripard
2025-04-25 10:26 ` [PATCH v4 07/23] drm/tests: hdmi: Replace '[_]MHz' with 'mhz' Cristian Ciocaltea
2025-04-26 2:06 ` Dmitry Baryshkov
2025-04-25 10:26 ` [PATCH v4 08/23] drm/tests: hdmi: Add macro to simplify EDID setup Cristian Ciocaltea
2025-04-28 9:52 ` Jani Nikula
2025-04-29 9:58 ` Cristian Ciocaltea
2025-05-13 13:45 ` Maxime Ripard
2025-04-25 10:27 ` [PATCH v4 09/23] drm/tests: hdmi: Replace open coded " Cristian Ciocaltea
2025-05-15 15:35 ` Maxime Ripard
2025-04-25 10:27 ` [PATCH v4 10/23] drm/tests: hdmi: Drop unused drm_kunit_helper_connector_hdmi_init_funcs() Cristian Ciocaltea
2025-05-16 13:06 ` Maxime Ripard
2025-04-25 10:27 ` [PATCH v4 11/23] drm/tests: hdmi: Setup ycbcr_420_allowed before initializing connector Cristian Ciocaltea
2025-04-25 10:27 ` [PATCH v4 12/23] drm/tests: helpers: Add a (re)try helper variant to enable CRTC connector Cristian Ciocaltea
2025-05-16 13:15 ` Maxime Ripard
2025-05-19 10:20 ` Cristian Ciocaltea
2025-04-25 10:27 ` [PATCH v4 13/23] drm/tests: hdmi: Switch to drm_kunit_helper_try_enable_crtc_connector() Cristian Ciocaltea
2025-04-25 10:27 ` [PATCH v4 14/23] drm/tests: hdmi: Add macro to support EDEADLK handling Cristian Ciocaltea
2025-05-19 7:22 ` Maxime Ripard
2025-05-19 10:35 ` Cristian Ciocaltea
2025-05-22 16:06 ` Maxime Ripard
2025-05-22 16:47 ` Cristian Ciocaltea
2025-05-26 6:44 ` Maxime Ripard
2025-04-25 10:27 ` [PATCH v4 15/23] drm/tests: hdmi: Restart atomic sequence on EDEADLK Cristian Ciocaltea
2025-04-25 10:27 ` [PATCH v4 16/23] drm/tests: hdmi: Switch to drm_atomic_get_new_connector_state() where possible Cristian Ciocaltea
2025-05-19 7:23 ` Maxime Ripard
2025-04-25 10:27 ` [PATCH v4 17/23] drm/tests: hdmi: Provide EDID supporting 4K@30Hz with YUV420 only Cristian Ciocaltea
2025-05-19 7:57 ` Maxime Ripard
2025-04-25 10:27 ` [PATCH v4 18/23] drm/tests: hdmi: Add limited range tests for YUV420 mode Cristian Ciocaltea
2025-05-19 7:58 ` Maxime Ripard
2025-04-25 10:27 ` [PATCH v4 19/23] drm/tests: hdmi: Rename max TMDS rate fallback tests Cristian Ciocaltea
2025-05-19 8:38 ` Maxime Ripard
2025-04-25 10:27 ` [PATCH v4 20/23] drm/tests: hdmi: Provide EDID supporting 4K@30Hz with RGB/YUV Cristian Ciocaltea
2025-05-19 7:57 ` Maxime Ripard
2025-04-25 10:27 ` [PATCH v4 21/23] drm/tests: hdmi: Add max TMDS rate fallback tests for YUV420 mode Cristian Ciocaltea
2025-05-19 8:40 ` Maxime Ripard
2025-04-25 10:27 ` [PATCH v4 22/23] drm/tests: hdmi: Add test for unsuccessful fallback to YUV420 Cristian Ciocaltea
2025-05-19 8:41 ` Maxime Ripard
2025-04-25 10:27 ` [PATCH v4 23/23] drm/tests: hdmi: Add test for unsupported RGB/YUV420 mode Cristian Ciocaltea
2025-05-19 8:42 ` Maxime Ripard
2025-05-19 10:55 ` Cristian Ciocaltea
2025-05-22 16:16 ` Maxime Ripard
2025-05-22 17:37 ` Cristian Ciocaltea
2025-05-27 12:59 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425-hdmi-conn-yuv-v4-4-5e55e2aaa3fa@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=airlied@gmail.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®