mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Lijo Lazar <lijo.lazar@amd.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	Alex Deucher <alexander.deucher@amd.com>,
	Kenneth Feng <kenneth.feng@amd.com>,
	linux-doc@vger.kernel.org
Subject: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/arcturus_ppt.c:1348: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Date: Sun, 27 Apr 2025 14:15:12 +0800	[thread overview]
Message-ID: <202504271422.D6cqMlZ0-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   02ddfb981de88a2c15621115dd7be2431252c568
commit: da868898cf4c5ddbd1f7406e356edce5d7211eb5 drm/amd/pm: Remove arcturus min power limit
date:   5 months ago
config: sparc-randconfig-001-20250426 (https://download.01.org/0day-ci/archive/20250427/202504271422.D6cqMlZ0-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250427/202504271422.D6cqMlZ0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504271422.D6cqMlZ0-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/arcturus_ppt.c:1348: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
            * No lower bound is imposed on the limit. Any unreasonable limit set


vim +1348 drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/arcturus_ppt.c

  1321	
  1322	static int arcturus_get_power_limit(struct smu_context *smu,
  1323						uint32_t *current_power_limit,
  1324						uint32_t *default_power_limit,
  1325						uint32_t *max_power_limit,
  1326						uint32_t *min_power_limit)
  1327	{
  1328		PPTable_t *pptable = smu->smu_table.driver_pptable;
  1329		uint32_t power_limit;
  1330	
  1331		if (smu_v11_0_get_current_power_limit(smu, &power_limit)) {
  1332			/* the last hope to figure out the ppt limit */
  1333			if (!pptable) {
  1334				dev_err(smu->adev->dev, "Cannot get PPT limit due to pptable missing!");
  1335				return -EINVAL;
  1336			}
  1337			power_limit =
  1338				pptable->SocketPowerLimitAc[PPT_THROTTLER_PPT0];
  1339		}
  1340	
  1341		if (current_power_limit)
  1342			*current_power_limit = power_limit;
  1343		if (default_power_limit)
  1344			*default_power_limit = power_limit;
  1345		if (max_power_limit)
  1346			*max_power_limit = power_limit;
  1347		/**
> 1348		 * No lower bound is imposed on the limit. Any unreasonable limit set
  1349		 * will result in frequent throttling.
  1350		 */
  1351		if (min_power_limit)
  1352			*min_power_limit = 0;
  1353	
  1354		return 0;
  1355	}
  1356	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2025-04-27  6:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202504271422.D6cqMlZ0-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=alexander.deucher@amd.com \
    --cc=kenneth.feng@amd.com \
    --cc=lijo.lazar@amd.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®