From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dmitry.baryshkov@oss.qualcomm.com,
loic.poulain@oss.qualcomm.com, vladimir.zapolskiy@linaro.org,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: media: qcom,x1e80100-camss: Fixup csiphy supply names
Date: Mon, 28 Apr 2025 09:14:09 +0200 [thread overview]
Message-ID: <20250428-lovely-flawless-grasshopper-bacbfa@kuoka> (raw)
In-Reply-To: <20250426-b4-media-committers-25-04-25-camss-supplies-v3-1-19e5e72ffc3e@linaro.org>
On Sat, Apr 26, 2025 at 11:52:48PM GMT, Bryan O'Donoghue wrote:
> Declare a CSIPHY regulator pair 0p8 and 1p2 for each CSIPHY.
>
> Name the inputs based on the voltage so as to have a consistent naming of
> these rails across SoCs and PCBs.
>
> There are no upstream users of this yaml definition yet so this change is
> safe to make.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../bindings/media/qcom,x1e80100-camss.yaml | 52 +++++++++++++++++-----
> 1 file changed, 40 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> index 113565cf2a991a8dcbc20889090e177e8bcadaac..dc7c1a9394c3b547f5e0885bf501ed42dfbeba88 100644
> --- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> @@ -118,14 +118,6 @@ properties:
> - const: ife1
> - const: top
>
> - vdd-csiphy-0p8-supply:
> - description:
> - Phandle to a 0.8V regulator supply to a PHY.
> -
> - vdd-csiphy-1p2-supply:
> - description:
> - Phandle to 1.8V regulator supply to a PHY.
> -
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
>
> @@ -157,6 +149,30 @@ properties:
> - clock-lanes
> - data-lanes
>
> + vdd-csiphy0-0p8-supply:
> + description: Phandle to a 0.8V regulator supply to csiphy0.
> +
> + vdd-csiphy0-1p2-supply:
> + description: Phandle to a 1.2V regulator supply to csiphy0.
Block has VDD_A_CSI_0_1_1P2 input, not separate one for CSI0 and CS1.
I don't get what is the benefit of this and commit msg does not help me
to understand such choice.
On IRC I clarified you could have less supplies in the binding than
number of actual pins, to make things simpler and more consistent, but
you did here reverse: more supplies which do not exist.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-28 7:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-26 22:52 [PATCH v3 0/2] media: qcom: camss: x1e80100: Add support for individual CSIPHY supplies Bryan O'Donoghue
2025-04-26 22:52 ` [PATCH v3 1/2] dt-bindings: media: qcom,x1e80100-camss: Fixup csiphy supply names Bryan O'Donoghue
2025-04-28 7:14 ` Krzysztof Kozlowski [this message]
2025-04-28 12:26 ` Bryan O'Donoghue
2025-04-26 22:52 ` [PATCH v3 2/2] media: qcom: camss: x1e80100: Fixup x1e " Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428-lovely-flawless-grasshopper-bacbfa@kuoka \
--to=krzk@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®