From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Alexandru Ardelean <aardelean@baylibre.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] util_macros.h: Make the header more resilient
Date: Mon, 28 Apr 2025 02:32:20 -0700 [thread overview]
Message-ID: <20250428023220.7cfab2286bb94f25c6bf7ca9@linux-foundation.org> (raw)
In-Reply-To: <20250428072754.3265274-1-andriy.shevchenko@linux.intel.com>
On Mon, 28 Apr 2025 10:27:54 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Add missing header inclusions and protect against double inclusion.
The patch doesn't "protect against double inclusion"?
> --- a/include/linux/util_macros.h
> +++ b/include/linux/util_macros.h
> @@ -2,7 +2,10 @@
> #ifndef _LINUX_HELPER_MACROS_H_
> #define _LINUX_HELPER_MACROS_H_
>
> +#include <linux/compiler_attributes.h>
> #include <linux/math.h>
> +#include <linux/typecheck.h>
> +#include <linux/stddef.h>
>
> /**
> * for_each_if - helper for handling conditionals in various for_each macros
> --
> 2.47.2
next prev parent reply other threads:[~2025-04-28 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 7:27 Andy Shevchenko
2025-04-28 9:32 ` Andrew Morton [this message]
2025-04-28 10:06 ` Andy Shevchenko
2025-04-28 21:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428023220.7cfab2286bb94f25c6bf7ca9@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aardelean@baylibre.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®