From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 550CD79F2; Mon, 28 Apr 2025 10:16:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745835397; cv=none; b=ElB6FJDDCsEdTw7pq0HXgFbp8aLN+4wm8LN/t6CreQXDCkcbzBtC1a4BC5tjKILGjRbb6aoM9osqsSxPxcihdOhVGwD8RS2wRxdhr5ulRottmTsng5iYAfqeOrBrkbwZBeARYaMXKxmy2kJ04+eNSINxLK8zjH72r6wkPzkDD2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745835397; c=relaxed/simple; bh=Q7cgqe+R5RLye1ej3E4XBmN/ZN/xMhAbSz+W/zM7mZo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eAMvUb1FP1TanmVyvigEWK6oVaBatp3/DqA3cytZ4pSCFwJNHi1Hwuu1V9XKFH1wL6LphkU6lRLy3Ks6UZP1yyH4RGuYVIenTxS9dF6WgP6T82iWocSXC4t4oNAD3SNuRfVtdYsoeP2dCDFjcxW71PIMkzaO7n8qfEDCScskgrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=CljZnVi0; arc=none smtp.client-ip=217.70.183.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="CljZnVi0" Received: by mail.gandi.net (Postfix) with ESMTPSA id A60E84396C; Mon, 28 Apr 2025 10:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1745835388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5aOZv2zdVkXsCWd9bP5Yd4I7as6l3L4TZW0Lw2hS1HA=; b=CljZnVi0ickz6gf0L4dBJL4EIrU93xzsDrr038fZY0AerxHfFIOjiuasmYdle0ECIiYBBR TnIvx4grk6Fo9M8Dp9RvGAQw4AuUT5SevFKn68mhSsQcnd98tdcwLZNKR1MgLyN/D02sfr gFqhAouAdhvIphwL6Kbo/z1i6yKtNReqX69ACzWRM17XU5wPs2razeqtWH2kvyyK6A0yGr TwmayLBWtmsx6/1AjXwG4adt+vFzIQuDkSZezFurNt9x74pU3uZx986Tz4GEW1vDmInF// jvx6EzGUgVPd06a8qoCHTqR7O7mdSLbN6KpqAd8xoKubao1JAV2w9GlFqcyh5g== Date: Mon, 28 Apr 2025 12:16:25 +0200 From: Kory Maincent To: Krzysztof Kozlowski Cc: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Laurent Pinchart , Thomas Petazzoni , Miquel Raynal , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH RFC v2 1/5] dt-bindings: display: panel: Fix port binding Message-ID: <20250428121625.72c0bfa8@kmaincent-XPS-13-7390> In-Reply-To: <20250428-refined-nyala-of-engineering-0556fb@kuoka> References: <20250424-feature_sfto340xc-v2-0-ff7da6192df2@bootlin.com> <20250424-feature_sfto340xc-v2-1-ff7da6192df2@bootlin.com> <20250428-refined-nyala-of-engineering-0556fb@kuoka> Organization: bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddviedtieekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtqhertdertdejnecuhfhrohhmpefmohhrhicuofgrihhntggvnhhtuceokhhorhihrdhmrghinhgtvghnthessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepgfdutdefvedtudegvefgvedtgfdvhfdtueeltefffefffffhgfetkedvfeduieeinecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecukfhppeeltddrkeelrdduieefrdduvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledtrdekledrudeifedruddvjedphhgvlhhopehkmhgrihhntggvnhhtqdgirffuqddufedqjeefledtpdhmrghilhhfrhhomhepkhhorhihrdhmrghinhgtvghnthessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepudelpdhrtghpthhtohepkhhriihksehkvghrnhgvlhdrohhrghdprhgtphhtthhopehnvghilhdrrghrmhhsthhrohhngheslhhinhgrrhhordhorhhgpdhrtghpthhtohepqhhuihgtpghjvghsshiihhgrnhesqhhuihgtihhntgdrtghomhdprhgtphhtthhopehmrggrrhhtvghnrdhlrghnkhhhohhrshhtsehli hhnuhigrdhinhhtvghlrdgtohhmpdhrtghpthhtohepmhhrihhprghrugeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepthiiihhmmhgvrhhmrghnnhesshhushgvrdguvgdprhgtphhtthhopegrihhrlhhivggusehgmhgrihhlrdgtohhmpdhrtghpthhtohepshhimhhonhgrsehffhiflhhlrdgthh X-GND-Sasl: kory.maincent@bootlin.com On Mon, 28 Apr 2025 09:32:21 +0200 Krzysztof Kozlowski wrote: > On Thu, Apr 24, 2025 at 05:07:39PM GMT, Kory Maincent wrote: > > Faced a binding error check while adding the data-lanes property in the > > ilitek,ili9881c binding. See the next patch for the binding changes. > > Here is the error: > > Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.example= .dtb: > > panel@0: port:endpoint: Unevaluated properties are not allowed > > ('data-lanes' was unexpected) =20 >=20 > There is no error at this point so your rationale is not correct. You > cannot use possible error as reason to fix something... You can use > instead other arguments that the binding is incomplete or incorrect. As I have said in the cover letter, I faced this error and this patch fixed= it but I didn't get the ins and outs. Indeed, I didn't understand the conflict between the port definition in panel-common and the panel binding change from the 2nd patch. > > Change the reference of properties/port to $defs/port-base to makes it > > work. > > The only difference between port and port-base is the unevaluatedProper= ty > > set to false. I have tried to use properties/port in both panel-common > > and ilitek,ili9881c bindings but the error is still there. The only way > > to not face the error is to use $defs/port-base reference. I don't > > really understand the ins and outs, maybe it is a issue from the binding > > check tool. > >=20 > > Signed-off-by: Kory Maincent > > --- > >=20 > > Changes in v2: > > - New patch > > --- > > Documentation/devicetree/bindings/display/panel/panel-common.yaml | 2 = +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git > > a/Documentation/devicetree/bindings/display/panel/panel-common.yaml > > b/Documentation/devicetree/bindings/display/panel/panel-common.yaml ind= ex > > 087415753d606ce67bceabaa9b0ba7d463282f92..635f67ced0cb7103684a1415ab740= d83409a7dbb > > 100644 --- > > a/Documentation/devicetree/bindings/display/panel/panel-common.yaml +++ > > b/Documentation/devicetree/bindings/display/panel/panel-common.yaml @@ > > -76,7 +76,7 @@ properties: # Connectivity port: > > - $ref: /schemas/graph.yaml#/properties/port > > + $ref: /schemas/graph.yaml#/$defs/port-base =20 >=20 > This allows anything in the port in every other binding, so is not > correct. You need to fully describe the port here with > additionalProps:false, probably. Just like every other binding with > port-base is doing. Yeah that was expected. As I said I tried with port-base but it throw me this error and I didn't ma= nage to remove it with only the panel binding change for now. Regards, --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com