From: "Ondřej Jirman" <megi@xff.cz>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Ondrej Jirman <megi@xff.cz>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] Fix inadverent sharing of struct ieee80211_supported_band data
Date: Tue, 29 Apr 2025 04:20:31 +0200 [thread overview]
Message-ID: <20250429022046.1656056-1-megi@xff.cz> (raw)
From: Ondrej Jirman <megi@xff.cz>
This is a series of patches requested by Ping-Ke Shih in response to
https://lore.kernel.org/lkml/20250427002414.410791-1-megi@xff.cz/
Please take a look.
(hw->wiphy->bands[*] are no longer being NULLed when probe fails and on
remove(), but I guess that should not be an issue? I tried unbinding the
device and it worked fine without any crash)
thank you and regards,
Ondrej Jirman
Changes since v1:
- added patch to convert some memory allocations to be devm_* managed
- check for NULL from kmemdup()
- rename rtw89_copy_sband
- drop some kfree due to them not being needed because failed
rtw89_core_set_supported_band() results in abandoned probe()
and devm_* will take care of that
- add error return to rtw89_init_he_eht_cap and check for it
Ondrej Jirman (2):
wifi: rtw89: Convert rtw89_core_set_supported_band to use devm_*
wifi: rtw89: Fix inadverent sharing of struct ieee80211_supported_band
data
drivers/net/wireless/realtek/rtw89/core.c | 124 +++++++++++-----------
1 file changed, 60 insertions(+), 64 deletions(-)
--
2.49.0
next reply other threads:[~2025-04-29 2:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 2:20 Ondřej Jirman [this message]
2025-04-29 2:20 ` [PATCH v2 1/2] wifi: rtw89: Convert rtw89_core_set_supported_band to use devm_* Ondřej Jirman
2025-04-29 6:27 ` Ping-Ke Shih
2025-04-29 2:20 ` [PATCH v2 2/2] wifi: rtw89: Fix inadverent sharing of struct ieee80211_supported_band data Ondřej Jirman
2025-04-29 6:37 ` Ping-Ke Shih
2025-04-29 6:16 ` [PATCH v2 0/2] " Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429022046.1656056-1-megi@xff.cz \
--to=megi@xff.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®