mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Jiri Slaby <jirislaby@kernel.org>, Peter Zijlstra <peterz@infradead.org>
Subject: [patch V2 11/45] genirq/chip: Prepare for code reduction
Date: Tue, 29 Apr 2025 08:55:04 +0200 (CEST)	[thread overview]
Message-ID: <20250429065420.682547546@linutronix.de> (raw)
In-Reply-To: <20250429065337.117370076@linutronix.de>

The interrupt flow handlers have similar patterns to decide whether to
handle an interrupt or not.

Provide common helper functions to allow removal of duplicated code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 kernel/irq/chip.c |   35 +++++++++++++++++++++++++++--------
 1 file changed, 27 insertions(+), 8 deletions(-)

--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -499,7 +499,7 @@ static bool irq_check_poll(struct irq_de
 	return irq_wait_for_poll(desc);
 }
 
-static bool irq_may_run(struct irq_desc *desc)
+static bool irq_can_handle_pm(struct irq_desc *desc)
 {
 	unsigned int mask = IRQD_IRQ_INPROGRESS | IRQD_WAKEUP_ARMED;
 
@@ -524,6 +524,25 @@ static bool irq_may_run(struct irq_desc
 	return irq_check_poll(desc);
 }
 
+static inline bool irq_can_handle_actions(struct irq_desc *desc)
+{
+	desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);
+
+	if (unlikely(!desc->action || irqd_irq_disabled(&desc->irq_data))) {
+		desc->istate |= IRQS_PENDING;
+		return false;
+	}
+	return true;
+}
+
+static inline bool irq_can_handle(struct irq_desc *desc)
+{
+	if (!irq_can_handle_pm(desc))
+		return false;
+
+	return irq_can_handle_actions(desc);
+}
+
 /**
  *	handle_simple_irq - Simple and software-decoded IRQs.
  *	@desc:	the interrupt description structure for this irq
@@ -539,7 +558,7 @@ void handle_simple_irq(struct irq_desc *
 {
 	raw_spin_lock(&desc->lock);
 
-	if (!irq_may_run(desc))
+	if (!irq_can_handle_pm(desc))
 		goto out_unlock;
 
 	desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);
@@ -574,7 +593,7 @@ void handle_untracked_irq(struct irq_des
 {
 	raw_spin_lock(&desc->lock);
 
-	if (!irq_may_run(desc))
+	if (!irq_can_handle_pm(desc))
 		goto out_unlock;
 
 	desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);
@@ -630,7 +649,7 @@ void handle_level_irq(struct irq_desc *d
 	raw_spin_lock(&desc->lock);
 	mask_ack_irq(desc);
 
-	if (!irq_may_run(desc))
+	if (!irq_can_handle_pm(desc))
 		goto out_unlock;
 
 	desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);
@@ -695,7 +714,7 @@ void handle_fasteoi_irq(struct irq_desc
 	 * can arrive on the new CPU before the original CPU has completed
 	 * handling the previous one - it may need to be resent.
 	 */
-	if (!irq_may_run(desc)) {
+	if (!irq_can_handle_pm(desc)) {
 		if (irqd_needs_resend_when_in_progress(&desc->irq_data))
 			desc->istate |= IRQS_PENDING;
 		goto out;
@@ -790,7 +809,7 @@ void handle_edge_irq(struct irq_desc *de
 
 	desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);
 
-	if (!irq_may_run(desc)) {
+	if (!irq_can_handle_pm(desc)) {
 		desc->istate |= IRQS_PENDING;
 		mask_ack_irq(desc);
 		goto out_unlock;
@@ -1166,7 +1185,7 @@ void handle_fasteoi_ack_irq(struct irq_d
 
 	raw_spin_lock(&desc->lock);
 
-	if (!irq_may_run(desc))
+	if (!irq_can_handle_pm(desc))
 		goto out;
 
 	desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);
@@ -1218,7 +1237,7 @@ void handle_fasteoi_mask_irq(struct irq_
 	raw_spin_lock(&desc->lock);
 	mask_ack_irq(desc);
 
-	if (!irq_may_run(desc))
+	if (!irq_can_handle_pm(desc))
 		goto out;
 
 	desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);


  parent reply	other threads:[~2025-04-29  6:55 UTC|newest]

Thread overview: 119+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29  6:54 [patch V2 00/45] genirq: Cleanups and conversion to lock guards Thomas Gleixner
2025-04-29  6:54 ` [patch V2 01/45] genirq: Provide conditional " Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:54 ` [patch V2 02/45] genirq/irqdesc: Switch to " Thomas Gleixner
2025-04-30  5:54   ` Jiri Slaby
2025-04-30  6:36     ` [patch V2a " Thomas Gleixner
2025-04-30  6:51       ` Jiri Slaby
2025-05-07  9:07       ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:54 ` [patch V2 03/45] genirq/autoprobe: " Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:54 ` [patch V2 04/45] genirq/pm: " Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:54 ` [patch V2 05/45] genirq/resend: " Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:54 ` [patch V2 06/45] genirq/proc: " Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-06-08 12:45   ` [patch V2 06/45] " Zenghui Yu
2025-06-09  7:15     ` Zenghui Yu
2025-06-09  7:28       ` Jiri Slaby
2025-06-09 10:00       ` Thomas Gleixner
2025-06-09  9:50     ` Thomas Gleixner
2025-04-29  6:54 ` [patch V2 07/45] genirq/spurious: Cleanup code Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:54 ` [patch V2 08/45] genirq/spurious: Switch to lock guards Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 09/45] genirq/cpuhotplug: Convert " Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
     [not found]   ` <CGME20250508145631eucas1p2f5369234fee8eb86761d70d028d6c82d@eucas1p2.samsung.com>
2025-05-08 14:56     ` [patch V2 09/45] " Marek Szyprowski
2025-05-08 17:53       ` Thomas Gleixner
2025-04-29  6:55 ` [patch V2 10/45] genirq/debugfs: " Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` Thomas Gleixner [this message]
2025-05-07  9:07   ` [tip: irq/core] genirq/chip: Prepare for code reduction tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 12/45] genirq/chip: Rework handle_nested_irq() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
     [not found]   ` <CGME20250508205629eucas1p2f8f2032c2d651be176acdf6ac4aa79cd@eucas1p2.samsung.com>
2025-05-08 20:56     ` [patch V2 12/45] " Marek Szyprowski
2025-05-09 18:37       ` Thomas Gleixner
2025-04-29  6:55 ` [patch V2 13/45] genirq/chip: Rework handle_simple_irq() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 14/45] genirq/chip: Rework handle_untracked_irq() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 15/45] genirq/chip: Rework handle_level_irq() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 16/45] genirq/chip: Rework handle_eoi_irq() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 17/45] genirq/chip: Rework handle_edge_irq() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 18/45] genirq/chip: Rework handle_fasteoi_ack_irq() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 19/45] genirq/chip: Rework handle_fasteoi_mask_irq() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 20/45] genirq/chip: Use lock guards where applicable Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 21/45] genirq/chip: Rework irq_set_chip() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 22/45] genirq/chip: Rework irq_set_irq_type() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 23/45] genirq/chip: Rework irq_set_handler_data() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 24/45] genirq/chip: Rework irq_set_msi_desc_off() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 25/45] genirq/chip: Rework irq_set_chip_data() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 26/45] genirq/chip: Rework irq_set_handler() variants Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-05-09 13:22   ` [patch V2 26/45] " Nathan Chancellor
2025-05-11 17:29     ` Miguel Ojeda
2025-05-11 17:49       ` Nathan Chancellor
2025-05-12  7:25         ` Jiri Slaby
2025-05-12  7:32           ` Jiri Slaby
2025-05-12  8:06             ` Jiri Slaby
2025-05-12 18:39           ` Thomas Gleixner
2025-04-29  6:55 ` [patch V2 27/45] genirq/chip: Rework irq_modify_status() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 28/45] genirq/manage: Cleanup kernel doc comments Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 29/45] genirq/manage: Convert to lock guards Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 30/45] genirq/manage: Rework irq_update_affinity_desc() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 31/45] genirq/manage: Rework __irq_apply_affinity_hint() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 32/45] genirq/manage: Rework irq_set_vcpu_affinity() Thomas Gleixner
2025-04-30  6:31   ` Jiri Slaby
2025-04-30 12:49     ` [patch V2a " Thomas Gleixner
2025-05-07  9:07       ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 33/45] genirq/manage: Rework __disable_irq_nosync() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 34/45] genirq/manage: Rework enable_irq() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 35/45] genirq/manage: Rework irq_set_irq_wake() Thomas Gleixner
2025-04-30  6:37   ` Jiri Slaby
2025-04-30 12:42     ` Thomas Gleixner
2025-04-30 12:48       ` [patch V2a " Thomas Gleixner
2025-05-07  9:07         ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-05-13 17:32         ` [patch V2a 35/45] " Jon Hunter
2025-05-13 22:55           ` Thomas Gleixner
2025-05-14  7:14             ` Jon Hunter
2025-04-29  6:55 ` [patch V2 36/45] genirq/manage: Rework can_request_irq() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 37/45] genirq/manage: Rework irq_set_parent() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 38/45] genirq/manage: Rework enable_percpu_irq() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 39/45] genirq/manage: Rework irq_percpu_is_enabled() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 40/45] genirq/manage: Rework disable_percpu_irq() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 41/45] genirq/manage: Rework prepare_percpu_nmi() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 42/45] genirq/manage: Rework teardown_percpu_nmi() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 43/45] genirq/manage: Rework irq_get_irqchip_state() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 44/45] genirq/manage: Rework irq_set_irqchip_state() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-04-29  6:55 ` [patch V2 45/45] genirq: Remove irq_[get|put]_desc*() Thomas Gleixner
2025-05-07  9:07   ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-05-06 14:24 ` [patch V2 00/45] genirq: Cleanups and conversion to lock guards Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250429065420.682547546@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®