From: Borislav Petkov <bp@alien8.de>
To: Annie Li <jiayanli@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Nikolay Borisov <nik.borisov@suse.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/microcode/amd: fix the return value when microcode has no update
Date: Tue, 29 Apr 2025 11:22:51 +0200 [thread overview]
Message-ID: <20250429092251.GEaBCaa2Y1tVOnl77A@fat_crate.local> (raw)
In-Reply-To: <20250429084317.1619909-1-jiayanli@google.com>
On Tue, Apr 29, 2025 at 08:43:16AM +0000, Annie Li wrote:
> In commit 6f059e634dcd("x86/microcode: Clarify the late load logic"), the
> return value is UCODE_OK if the load is up-to-date in amd platform, which
> leads to load_late_locked() returning -EBADFD.
>
> This is different from the intel platform, which will return UCODE_NFOUND
> and is more reasonable.
>
> Fix the return to UCODE_NFOUND to avoid -EBADFD error.
... and return -ENOENT instead?
Is that better?
Or would it be even better for the switch-case to handle UCODE_OK too?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2025-04-29 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 8:43 Annie Li
2025-04-29 9:22 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429092251.GEaBCaa2Y1tVOnl77A@fat_crate.local \
--to=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jiayanli@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®