From: Yabin Cui <yabinc@google.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>, Leo Yan <leo.yan@arm.com>,
Jie Gan <quic_jiegan@quicinc.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Yabin Cui <yabinc@google.com>
Subject: [PATCH v5 0/2] coresight: catu: Introduce refcount and spinlock for enabling/disabling
Date: Tue, 29 Apr 2025 16:12:58 -0700 [thread overview]
Message-ID: <20250429231301.1952246-1-yabinc@google.com> (raw)
Hi Coresight maintainers,
When tracing ETM data on multiple CPUs concurrently via the
perf interface, the CATU device is shared across different CPU
paths. This can lead to race conditions when multiple CPUs attempt
to enable or disable the CATU device simultaneously. This patchset
is to fix race conditions when enabling/disabling a CATU device.
Changes since v4:
- Collect Review-by tags.
- return -EINVAL for unknown types in coresight_enable_path.
Changes since v3:
- Add newlines between variable definition and guard().
- Add path parameter when calling coresight_disable_helpers.
- Use "goto err_disable_helpers" in coresight_enable_path().
Changes since v2:
- In catu_disable(), return 0 when refcnt > 0.
- Remove the patch checking enabled mode.
- Disable helpers at the places where a coresight device fails to
enable.
Changes since v1:
- Use raw_spinlock_t and guard().
- Add a patch to check enabled mode.
- Add a patch to disable helpers when fails to enable a device.
Yabin Cui (2):
coresight: catu: Introduce refcount and spinlock for
enabling/disabling
coresight: core: Disable helpers for devices that fail to enable
drivers/hwtracing/coresight/coresight-catu.c | 25 +++++++++++++-------
drivers/hwtracing/coresight/coresight-catu.h | 1 +
drivers/hwtracing/coresight/coresight-core.c | 11 ++++++---
3 files changed, 26 insertions(+), 11 deletions(-)
--
2.49.0.967.g6a0df3ecc3-goog
next reply other threads:[~2025-04-29 23:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 23:12 Yabin Cui [this message]
2025-04-29 23:12 ` [PATCH v5 1/2] " Yabin Cui
2025-04-30 13:45 ` Suzuki K Poulose
2025-04-29 23:13 ` [PATCH v5 2/2] coresight: core: Disable helpers for devices that fail to enable Yabin Cui
2025-04-30 12:57 ` Leo Yan
2025-04-30 13:45 ` Suzuki K Poulose
2025-04-30 13:55 ` [PATCH v5 0/2] coresight: catu: Introduce refcount and spinlock for enabling/disabling Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429231301.1952246-1-yabinc@google.com \
--to=yabinc@google.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=quic_jiegan@quicinc.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®