From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Davidlohr Bueso <dave@stgolabs.net>, Jan Kara <jack@suse.cz>,
kdevops@lists.linux.dev, Luis Chamberlain <mcgrof@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Sasha Levin <sashal@kernel.org>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: [PATCH AUTOSEL 6.12 27/37] fs/buffer: use sleeping version of __find_get_block()
Date: Tue, 29 Apr 2025 19:51:12 -0400 [thread overview]
Message-ID: <20250429235122.537321-27-sashal@kernel.org> (raw)
In-Reply-To: <20250429235122.537321-1-sashal@kernel.org>
From: Davidlohr Bueso <dave@stgolabs.net>
[ Upstream commit 5b67d43976828dea2394eae2556b369bb7a61f64 ]
Convert to the new nonatomic flavor to benefit from potential performance
benefits and adapt in the future vs migration such that semantics
are kept.
Convert write_boundary_block() which already takes the buffer
lock as well as bdev_getblk() depending on the respective gpf flags.
There are no changes in semantics.
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
Link: https://kdevops.org/ext4/v6.15-rc2.html # [0]
Link: https://lore.kernel.org/all/aAAEvcrmREWa1SKF@bombadil.infradead.org/ # [1]
Link: https://lore.kernel.org/20250418015921.132400-4-dave@stgolabs.net
Tested-by: kdevops@lists.linux.dev # [0] [1]
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
fs/buffer.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index b04705eb6cc57..e9e84512a027a 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -658,7 +658,9 @@ EXPORT_SYMBOL(generic_buffers_fsync);
void write_boundary_block(struct block_device *bdev,
sector_t bblock, unsigned blocksize)
{
- struct buffer_head *bh = __find_get_block(bdev, bblock + 1, blocksize);
+ struct buffer_head *bh;
+
+ bh = __find_get_block_nonatomic(bdev, bblock + 1, blocksize);
if (bh) {
if (buffer_dirty(bh))
write_dirty_buffer(bh, 0);
@@ -1446,7 +1448,12 @@ EXPORT_SYMBOL(__find_get_block_nonatomic);
struct buffer_head *bdev_getblk(struct block_device *bdev, sector_t block,
unsigned size, gfp_t gfp)
{
- struct buffer_head *bh = __find_get_block(bdev, block, size);
+ struct buffer_head *bh;
+
+ if (gfpflags_allow_blocking(gfp))
+ bh = __find_get_block_nonatomic(bdev, block, size);
+ else
+ bh = __find_get_block(bdev, block, size);
might_alloc(gfp);
if (bh)
--
2.39.5
next prev parent reply other threads:[~2025-04-29 23:52 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 23:50 [PATCH AUTOSEL 6.12 01/37] cpufreq: Add SM8650 to cpufreq-dt-platdev blocklist Sasha Levin
2025-04-29 23:50 ` [PATCH AUTOSEL 6.12 02/37] cpufreq: Do not enable by default during compile testing Sasha Levin
2025-04-29 23:50 ` [PATCH AUTOSEL 6.12 03/37] nvmem: rockchip-otp: Move read-offset into variant-data Sasha Levin
2025-04-29 23:50 ` [PATCH AUTOSEL 6.12 04/37] nvmem: rockchip-otp: add rk3576 variant data Sasha Levin
2025-04-29 23:50 ` [PATCH AUTOSEL 6.12 05/37] nvmem: core: fix bit offsets of more than one byte Sasha Levin
2025-04-29 23:50 ` [PATCH AUTOSEL 6.12 06/37] nvmem: core: verify cell's raw_len Sasha Levin
2025-04-29 23:50 ` [PATCH AUTOSEL 6.12 07/37] nvmem: core: update raw_len if the bit reading is required Sasha Levin
2025-04-29 23:50 ` [PATCH AUTOSEL 6.12 08/37] nvmem: qfprom: switch to 4-byte aligned reads Sasha Levin
2025-04-29 23:50 ` [PATCH AUTOSEL 6.12 09/37] scsi: target: iscsi: Fix timeout on deleted connection Sasha Levin
2025-04-29 23:50 ` [PATCH AUTOSEL 6.12 10/37] scsi: ufs: Introduce quirk to extend PA_HIBERN8TIME for UFS devices Sasha Levin
2025-04-29 23:50 ` [PATCH AUTOSEL 6.12 11/37] virtio_ring: Fix data race by tagging event_triggered as racy for KCSAN Sasha Levin
2025-04-29 23:50 ` [PATCH AUTOSEL 6.12 12/37] dma/mapping.c: dev_dbg support for dma_addressing_limited Sasha Levin
2025-04-29 23:50 ` [PATCH AUTOSEL 6.12 13/37] intel_th: avoid using deprecated page->mapping, index fields Sasha Levin
2025-04-29 23:50 ` [PATCH AUTOSEL 6.12 14/37] driver core: introduce device_set_driver() helper Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 15/37] driver core: fix potential NULL pointer dereference in dev_uevent() Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 16/37] mei: vsc: Use struct vsc_tp_packet as vsc-tp tx_buf and rx_buf type Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 17/37] dma-mapping: avoid potential unused data compilation warning Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 18/37] cgroup: Fix compilation issue due to cgroup_mutex not being exported Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 19/37] vhost_task: fix vhost_task_create() documentation Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 20/37] vhost-scsi: protect vq->log_used with vq->mutex Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 21/37] scsi: mpi3mr: Add level check to control event logging Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 22/37] net: enetc: refactor bulk flipping of RX buffers to separate function Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 23/37] dma-mapping: Fix warning reported for missing prototype Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 24/37] ima: process_measurement() needlessly takes inode_lock() on MAY_READ Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 25/37] fs/buffer: split locking for pagecache lookups Sasha Levin
2025-04-30 0:48 ` Luis Chamberlain
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 26/37] fs/buffer: introduce sleeping flavors " Sasha Levin
2025-04-29 23:51 ` Sasha Levin [this message]
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 28/37] fs/ocfs2: use sleeping version of __find_get_block() Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 29/37] fs/jbd2: " Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 30/37] fs/ext4: use sleeping version of sb_find_get_block() Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 31/37] drm/amd/display: Enable urgent latency adjustment on DCN35 Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 32/37] drm/amdgpu: Allow P2P access through XGMI Sasha Levin
2025-04-30 12:58 ` Alex Deucher
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 33/37] selftests/bpf: Mitigate sockmap_ktls disconnect_after_delete failure Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 34/37] block: fix race between set_blocksize and read paths Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 35/37] io_uring: don't duplicate flushing in io_req_post_cqe Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 36/37] bpf: fix possible endless loop in BPF map iteration Sasha Levin
2025-04-29 23:51 ` [PATCH AUTOSEL 6.12 37/37] samples/bpf: Fix compilation failure for samples/bpf on LoongArch Fedora Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429235122.537321-27-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=brauner@kernel.org \
--cc=dave@stgolabs.net \
--cc=jack@suse.cz \
--cc=kdevops@lists.linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®