From: Andrew Jones <ajones@ventanamicro.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, 18255117159@163.com
Subject: [PATCH] genirq/msi: Fix MSI domain debugfs show
Date: Wed, 30 Apr 2025 14:48:37 +0200 [thread overview]
Message-ID: <20250430124836.49964-2-ajones@ventanamicro.com> (raw)
irq_domain_debug_show_one() calls the irqdomain's debug_show() with
a non-null domain pointer and a null irqdata pointer
(irq_debug_show_data() calls debug_show() with those the other way
around). Ensure we have a non-null irqdata pointer in
msi_domain_debug_show() before dereferencing it.
Fixes: 01499ae673dc ("genirq/msi: Expose MSI message data in debugfs")
Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
---
kernel/irq/msi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index 5c8d43cdb0a3..c05ba7ca00fa 100644
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -761,7 +761,7 @@ static int msi_domain_translate(struct irq_domain *domain, struct irq_fwspec *fw
static void msi_domain_debug_show(struct seq_file *m, struct irq_domain *d,
struct irq_data *irqd, int ind)
{
- struct msi_desc *desc = irq_data_get_msi_desc(irqd);
+ struct msi_desc *desc = irqd ? irq_data_get_msi_desc(irqd) : NULL;
if (!desc)
return;
--
2.49.0
next reply other threads:[~2025-04-30 12:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 12:48 Andrew Jones [this message]
2025-04-30 21:32 ` [tip: irq/urgent] genirq/msi: Prevent NULL pointer dereference in msi_domain_debug_show() tip-bot2 for Andrew Jones
2025-05-01 1:51 ` [PATCH] genirq/msi: Fix MSI domain debugfs show Hans Zhang
2025-05-02 7:33 ` Andrew Jones
2025-05-02 8:40 ` Hans Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250430124836.49964-2-ajones@ventanamicro.com \
--to=ajones@ventanamicro.com \
--cc=18255117159@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome