Re: [linux-next]Build Failure: kernel/watchdog.c:936:2: error: too many arguments

[Stephen Rothwell <sfr@canb.auug.org.au>]

[-- Attachment #1: Type: text/plain, Size: 3116 bytes --]

Hi Venkat,

On Wed, 30 Apr 2025 11:57:12 +0530 Venkat Rao Bagalkote <venkat88@linux.ibm.com> wrote:
>
> On 28/04/25 3:11 pm, Venkat Rao Bagalkote wrote:
> >
> > On 28/04/25 4:11 am, Stephen Rothwell wrote:  
> >>
> >> On Sat, 26 Apr 2025 20:39:26 +0530 Venkat Rao Bagalkote >> <venkat88@linux.ibm.com> wrote:  
> >>> I am observing below build failure on IBM Power8 server with >>> linux-next-20250424 repo.
> >>>
> >>> This issue seems to be introduced by the below commit. After >>> reverting the below commit, kernel build is successful.
> >>>
> >>> Bad Commit: 6b07f9a0fa41 watchdog: fix watchdog may detect false >>> positive of softlockup
> >>>
> >>> Note: To hit this issue, one should first resolve this [1] >>> <https://lore.kernel.org/all/e8bf676e-7bf0-4896-b104-ac75e1b22d2e@linux.ibm.com/>
> >>>
> >>> Repo: >>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >>> Branch: master
> >>> GCC: 8.5.0 20210514
> >>> ldd (GNU libc) 2.28
> >>>
> >>> Attached is the .config file.
> >>>
> >>> Errors:
> >>>
> >>> kernel/watchdog.c: In function 'lockup_detector_reconfigure':
> >>> kernel/watchdog.c:936:2: error: too many arguments to function >>> '__lockup_detector_reconfigure'
> >>>     __lockup_detector_reconfigure(false);
> >>>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>> kernel/watchdog.c:926:13: note: declared here
> >>>    static void __lockup_detector_reconfigure(void)
> >>>                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>> kernel/watchdog.c: In function 'lockup_detector_setup':
> >>> kernel/watchdog.c:940:2: error: too many arguments to function >>> '__lockup_detector_reconfigure'
> >>>     __lockup_detector_reconfigure(false);
> >>>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>> kernel/watchdog.c:926:13: note: declared here
> >>>    static void __lockup_detector_reconfigure(void)
> >>>                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>> kernel/watchdog.c: In function 'proc_watchdog_update':
> >>> kernel/watchdog.c:962:2: error: too many arguments to function >>> '__lockup_detector_reconfigure'
> >>>     __lockup_detector_reconfigure(thresh_changed);
> >>>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>> kernel/watchdog.c:926:13: note: declared here
> >>>    static void __lockup_detector_reconfigure(void)
> >>>                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>>
> >>> If you happen to fix this, please add below tag.
> >>>
> >>> Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>  
> >> Yeah, the CONFIG_SOFTLOCKUP_DETECTOR unset version of
> >> __lockup_detector_reconfigure() was not updated :-(  
> >  
> 
> Hello Stephen,
> 
> 
> Will this be fixed, or from now on we will have to set the SOFTLOCKUP_DETECTOR always in the .config file.
> 
> 
> Trying to understand the way forward.

Yeah, it is still not fixed today :-(  hopefully soon.

This is caused by commit

  4ab274088f03 ("watchdog: fix watchdog may detect false positive of softlockup")

in the mm-nonmm-unstable tree.  I have reverted it today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]