From: Lee Jones <lee@kernel.org>
To: lee@kernel.org, Pavel Machek <pavel@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: bettyzhou@google.com, ynaffit@google.com, tkjos@google.com,
jacek.anaszewski@gmail.com
Subject: [PATCH 1/3] led: led-test: Remove standard error checking after KUNIT_ASSERT_*()
Date: Thu, 1 May 2025 09:19:11 +0100 [thread overview]
Message-ID: <20250501081918.3621432-1-lee@kernel.org> (raw)
If a KUNIT_ASSERT_*() call ends up in an assertion, the test is marked
as a failure and the subsequent error checking is never executed, making
it superfluous. Remove it for simplicity and to avoid confusion.
Signed-off-by: Lee Jones <lee@kernel.org>
---
drivers/leds/led-test.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c
index 068c9d0eb683..23820189abe3 100644
--- a/drivers/leds/led-test.c
+++ b/drivers/leds/led-test.c
@@ -26,8 +26,6 @@ static void led_test_class_register(struct kunit *test)
ret = devm_led_classdev_register(dev, cdev);
KUNIT_ASSERT_EQ(test, ret, 0);
- if (ret)
- return;
}
static struct kunit_case led_test_cases[] = {
--
2.49.0.906.g1f30a19c02-goog
next reply other threads:[~2025-05-01 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 8:19 Lee Jones [this message]
2025-05-01 8:19 ` [PATCH 2/3] leds: led-test: Fill out the registration test to cover more test cases Lee Jones
2025-05-01 8:19 ` [PATCH 3/3] leds: led-test: Provide tests for the lookup and get infrastructure Lee Jones
2025-05-08 13:53 ` [PATCH 1/3] led: led-test: Remove standard error checking after KUNIT_ASSERT_*() Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250501081918.3621432-1-lee@kernel.org \
--to=lee@kernel.org \
--cc=bettyzhou@google.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=tkjos@google.com \
--cc=ynaffit@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®