From: Paul Cacheux via B4 Relay <devnull+paulcacheux.gmail.com@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Namhyung Kim <namhyung@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Paul Cacheux <paulcacheux@gmail.com>
Subject: [PATCH v2 1/2] tracing: add missing trace_probe_log_clear for eprobes
Date: Fri, 02 May 2025 15:15:52 +0200 [thread overview]
Message-ID: <20250502-fix-trace-probe-log-race-v2-1-511ecc1521ec@gmail.com> (raw)
In-Reply-To: <20250502-fix-trace-probe-log-race-v2-0-511ecc1521ec@gmail.com>
From: Paul Cacheux <paulcacheux@gmail.com>
Make sure trace_probe_log_clear is called in the tracing
eprobe code path, matching the trace_probe_log_init call.
Signed-off-by: Paul Cacheux <paulcacheux@gmail.com>
---
kernel/trace/trace_eprobe.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
index c08355c3ef32b4124ac944d7e3a03efb66492269..916555f0de811f03feed9d923c63078b0e4c993b 100644
--- a/kernel/trace/trace_eprobe.c
+++ b/kernel/trace/trace_eprobe.c
@@ -969,10 +969,13 @@ static int __trace_eprobe_create(int argc, const char *argv[])
goto error;
}
}
+ trace_probe_log_clear();
return ret;
+
parse_error:
ret = -EINVAL;
error:
+ trace_probe_log_clear();
trace_event_probe_cleanup(ep);
return ret;
}
--
2.49.0
next prev parent reply other threads:[~2025-05-02 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 13:15 [PATCH v2 0/2] tracing: fix race when creating trace probe log error message Paul Cacheux via B4 Relay
2025-05-02 13:15 ` Paul Cacheux via B4 Relay [this message]
2025-05-09 22:18 ` [PATCH v2 1/2] tracing: add missing trace_probe_log_clear for eprobes Masami Hiramatsu
2025-05-02 13:15 ` [PATCH v2 2/2] tracing: protect trace_probe_log with mutex Paul Cacheux via B4 Relay
2025-05-02 13:50 ` Steven Rostedt
2025-05-07 6:49 ` Paul Cacheux
2025-05-09 22:44 ` Masami Hiramatsu
2025-05-09 23:57 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250502-fix-trace-probe-log-race-v2-1-511ecc1521ec@gmail.com \
--to=devnull+paulcacheux.gmail.com@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulcacheux@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®