From: David Lechner <dlechner@baylibre.com>
To: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Esteban Blanc" <eblanc@baylibre.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Andy Shevchenko" <andy@kernel.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
kernel@pengutronix.de, "Song Qiang" <songqiang1304521@gmail.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
David Lechner <dlechner@baylibre.com>
Subject: [PATCH 03/14] iio: chemical: bme680_spi: remove bits_per_word = 8
Date: Mon, 05 May 2025 14:20:30 -0500 [thread overview]
Message-ID: <20250505-iio-remove-bits_per_word-8-v1-3-341f85fcfe11@baylibre.com> (raw)
In-Reply-To: <20250505-iio-remove-bits_per_word-8-v1-0-341f85fcfe11@baylibre.com>
Remove setting bits_per_word = 8 from the bme680 driver. This is the
default value for SPI transfers, so it is not necessary to explicitly
set it.
Since no other SPI settings are changed, we can also remove the call to
spi_setup().
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
drivers/iio/chemical/bme680_spi.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/iio/chemical/bme680_spi.c b/drivers/iio/chemical/bme680_spi.c
index ced5af23846a73e0378dc936b2cf8c9508760301..aa97645ba539f6a591112d6554b893814d1ac418 100644
--- a/drivers/iio/chemical/bme680_spi.c
+++ b/drivers/iio/chemical/bme680_spi.c
@@ -112,14 +112,6 @@ static int bme680_spi_probe(struct spi_device *spi)
const struct spi_device_id *id = spi_get_device_id(spi);
struct bme680_spi_bus_context *bus_context;
struct regmap *regmap;
- int ret;
-
- spi->bits_per_word = 8;
- ret = spi_setup(spi);
- if (ret < 0) {
- dev_err(&spi->dev, "spi_setup failed!\n");
- return ret;
- }
bus_context = devm_kzalloc(&spi->dev, sizeof(*bus_context), GFP_KERNEL);
if (!bus_context)
--
2.43.0
next prev parent reply other threads:[~2025-05-05 19:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 19:20 [PATCH 00/14] iio: remove bits_per_word = 8 assignments David Lechner
2025-05-05 19:20 ` [PATCH 01/14] iio: adc: ad4030: remove bits_per_word = 8 David Lechner
2025-05-05 19:20 ` [PATCH 02/14] iio: adc: ti-tsc2046: " David Lechner
2025-05-06 4:48 ` Oleksij Rempel
2025-05-05 19:20 ` David Lechner [this message]
2025-05-05 19:20 ` [PATCH 04/14] iio: dac: ad5761: " David Lechner
2025-05-05 19:20 ` [PATCH 05/14] iio: dac: ad5766: " David Lechner
2025-05-05 19:20 ` [PATCH 06/14] iio: dac: ad5791: " David Lechner
2025-05-05 19:20 ` [PATCH 07/14] iio: dac: ltc2688: " David Lechner
2025-05-05 19:20 ` [PATCH 08/14] iio: gyro: adxrs450: " David Lechner
2025-05-05 19:20 ` [PATCH 09/14] iio: imu: adis: " David Lechner
2025-05-05 19:20 ` [PATCH 10/14] iio: magnetometer: hmc5843_spi: " David Lechner
2025-05-05 19:20 ` [PATCH 11/14] iio: magnetometer: rm3100-spi: " David Lechner
2025-05-05 19:20 ` [PATCH 12/14] iio: pressure: bmp280-spi: " David Lechner
2025-05-05 19:20 ` [PATCH 13/14] iio: pressure: ms5611_spi: " David Lechner
2025-05-05 19:20 ` [PATCH 14/14] iio: pressure: zpa2326_spi: " David Lechner
2025-05-07 6:28 ` [PATCH 00/14] iio: remove bits_per_word = 8 assignments Nuno Sá
2025-05-07 19:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505-iio-remove-bits_per_word-8-v1-3-341f85fcfe11@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=eblanc@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=o.rempel@pengutronix.de \
--cc=songqiang1304521@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®