mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Angelo Dureghello <adureghello@baylibre.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Nuno Sa <nuno.sa@analog.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	David Lechner <dlechner@baylibre.com>,
	Andy Shevchenko <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] iio: dac: adi-axi-dac: fix for wrong bus read
Date: Mon, 5 May 2025 13:38:01 +0100	[thread overview]
Message-ID: <20250505133801.372738d7@jic23-huawei> (raw)
In-Reply-To: <zca24hgtpycx3l2knyqdt3eu7mfyulzxjphsypae2jzxjgvbsu@2kslj4tcihv4>

On Mon, 5 May 2025 13:33:16 +0200
Angelo Dureghello <adureghello@baylibre.com> wrote:

> Hi Jonathan,
> 
> asking info about this patch.
> 
> As explained, would not do anything else here, please let me know if it can
> be accepted or how to proceed.
I've queued up patch 1 as a fix.  Patch 2 will need to wait on that.

> 
> Thanks a lot,
> angelo
> 
> On 09.04.2025 14:57, Nuno Sá wrote:
> > On Wed, 2025-04-09 at 11:16 +0200, Angelo Dureghello wrote:  
> > > This patchset is intended to fix a random wrong chip ID read, or a
> > > scratchpad test mismatch, tests done in the ad3552r-hs driver probe. The 
> > > bus "read" operation must always check for busy flag before reading.
> > > 
> > > First patch reorganizes a bit the busy-wait polling code, second patch
> > > fixes the wrong bus read occurence. 
> > > 
> > > NOTE: due to ongoing changes in adi-axi-dac.c, this patch is intended to be
> > > applied after the linked "ramp generator" patch.
> > > 
> > > Link:
> > > https://lore.kernel.org/linux-iio/20250408-wip-bl-ad3552r-fixes-v4-0-b33c0264bd78@baylibre.com
> > > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> > > ---  
> > 
> > LGTM,
> > 
> > Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> >   
> > > Changes in v2:
> > > - invert patch order, fix first.
> > > - Link to v1:
> > > https://lore.kernel.org/r/20250408-ad3552r-fix-bus-read-v1-0-37add66aeb08@baylibre.com
> > > 
> > > ---
> > > Angelo Dureghello (2):
> > >       iio: dac: adi-axi-dac: fix bus read
> > >       iio: dac: adi-axi-dac: use unique bus free check
> > > 
> > >  drivers/iio/dac/adi-axi-dac.c | 40 +++++++++++++++++++++++++---------------
> > >  1 file changed, 25 insertions(+), 15 deletions(-)
> > > ---
> > > base-commit: 6fb85f14853ddde06d57030c753168402bf69cd9
> > > change-id: 20250408-ad3552r-fix-bus-read-1522622fbd2b
> > > 
> > > Best regards,  
> 


  reply	other threads:[~2025-05-05 12:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-09  9:16 Angelo Dureghello
2025-04-09  9:16 ` [PATCH v2 1/2] iio: dac: adi-axi-dac: fix " Angelo Dureghello
2025-04-09 16:49   ` Andy Shevchenko
2025-04-12 13:00     ` Jonathan Cameron
2025-04-12 18:03       ` Andy Shevchenko
2025-04-09  9:16 ` [PATCH v2 2/2] iio: dac: adi-axi-dac: use unique bus free check Angelo Dureghello
2025-04-09 16:51   ` Andy Shevchenko
2025-04-29 14:32     ` Angelo Dureghello
2025-04-29 22:05       ` Andy Shevchenko
2025-04-30 14:15         ` Angelo Dureghello
2025-04-09 13:57 ` [PATCH v2 0/2] iio: dac: adi-axi-dac: fix for wrong bus read Nuno Sá
2025-04-22  8:41   ` Angelo Dureghello
2025-05-05 11:33   ` Angelo Dureghello
2025-05-05 12:38     ` Jonathan Cameron [this message]
2025-05-19 19:03       ` Angelo Dureghello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250505133801.372738d7@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=adureghello@baylibre.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®