From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6345C3745B2; Mon, 5 May 2025 23:06:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746486367; cv=none; b=BgWCL/0MFLHU7yMjrnavkSZoxwe7VEM3kQGGReB4OHo50uKE4i2slJVwdnM8U3bS5R7FKo5T0P1yuzpPXDKVZ4yBjSg+gEZd4FjktfQ/KIls/TJPVdlb0Q1MPQhgfXPig42Uv+4hjUhCABRs0srhppMaHyqVomVQu27F9ldbrNI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746486367; c=relaxed/simple; bh=5fB5oUZhc39xpZeWHqD2PSF7T88HaYAVhdoLWGMnc+o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XXprjx5baWM4vur3dd8EdVjVOHg6aB/lIu+jokwQ43mWgvKHwOomo8i2+Eqlr8ofdoM4zQ5cx67mWAcNKmW1KMIQc4VIY5Og4FAHwXn66KR4kwewc30jroQ4syxBAEwN6z/SxKehSmp7RCL9WMN+We2ZQItsgKRFRLCdengaMig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mpOB0zzE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mpOB0zzE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72F04C4CEEF; Mon, 5 May 2025 23:06:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746486366; bh=5fB5oUZhc39xpZeWHqD2PSF7T88HaYAVhdoLWGMnc+o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mpOB0zzESvka06/Jx4JKj5826rPwD0Oy9RFKMn4HZBUjIsyTrdjZM6YwxfgEOIC0p 6HPGkAWOgLMgaR++yPsqx9sQ4nBljUeYzc2OUo3MItPQawabN122lGFwLU7tSu/7Aw myUsZ4PIFlMMDMbpatZgiUiY+/gabJEwQ8T7c6HahlOQmop8MqXulbU8LtFezXex/X gWjhT7OUzpTF2ZvjrBTL2Xq5YRRxUa3M9jF1meMSi1uUvll2cdLwoRoVQ/i0USQ0cJ aYF5FpVVJ2xsgkYmaqrt8UWU3b/JDPeOHFwfodZSJTkneddBo5QI3HwnTI98YwCRrE N0+q0ryJ2o8Aw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Isaac Scott , Michael Hennerich , Mark Brown , Sasha Levin , lgirdwood@gmail.com Subject: [PATCH AUTOSEL 6.6 285/294] regulator: ad5398: Add device tree support Date: Mon, 5 May 2025 18:56:25 -0400 Message-Id: <20250505225634.2688578-285-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505225634.2688578-1-sashal@kernel.org> References: <20250505225634.2688578-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.89 Content-Transfer-Encoding: 8bit From: Isaac Scott [ Upstream commit 5a6a461079decea452fdcae955bccecf92e07e97 ] Previously, the ad5398 driver used only platform_data, which is deprecated in favour of device tree. This caused the AD5398 to fail to probe as it could not load its init_data. If the AD5398 has a device tree node, pull the init_data from there using of_get_regulator_init_data. Signed-off-by: Isaac Scott Acked-by: Michael Hennerich Link: https://patch.msgid.link/20250128173143.959600-4-isaac.scott@ideasonboard.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/ad5398.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c index 40f7dba42b5ad..404cbe32711e7 100644 --- a/drivers/regulator/ad5398.c +++ b/drivers/regulator/ad5398.c @@ -14,6 +14,7 @@ #include #include #include +#include #define AD5398_CURRENT_EN_MASK 0x8000 @@ -221,15 +222,20 @@ static int ad5398_probe(struct i2c_client *client) const struct ad5398_current_data_format *df = (struct ad5398_current_data_format *)id->driver_data; - if (!init_data) - return -EINVAL; - chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); if (!chip) return -ENOMEM; config.dev = &client->dev; + if (client->dev.of_node) + init_data = of_get_regulator_init_data(&client->dev, + client->dev.of_node, + &ad5398_reg); + if (!init_data) + return -EINVAL; + config.init_data = init_data; + config.of_node = client->dev.of_node; config.driver_data = chip; chip->client = client; -- 2.39.5