From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80F4F2F665D; Mon, 5 May 2025 23:18:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487097; cv=none; b=Fq4Xbcrfp8nXWycXoe+HBid0nfSGq3yGJzWfw4cVmriv75n8kt4cOwy7Yz8jbxx3CLIIOd4JEHtKrxWYv+AvpQvUXfzSLzbLEVphqkLzpVm7NWmWCC9Pp8dluy5BiE4LdJHmgdy9WLlMNNzhOSw35sAjd7j30xbKodk/mdofpfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487097; c=relaxed/simple; bh=O1AXRcVzO+bLHxqo7eor34N1+WCsiJkmsH6UzahIF4U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GnCANHm5AMwznVv3cgkxhBTETcoVqqWPelC6tG7wuiRKUlEG8Ch95MoR7vRY0zkhPG8Gq+X1ngnmoilj0UQkuy346+BwMwCrhAjbZLw/16Ch0uLiQPYV/3hlFU3cYb/VIyq1A3g0fShB6H9uN5mJyM2jvPBZdWYHOGOfJe97wks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cKwxxp1y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cKwxxp1y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1982C4CEEF; Mon, 5 May 2025 23:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746487096; bh=O1AXRcVzO+bLHxqo7eor34N1+WCsiJkmsH6UzahIF4U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cKwxxp1yY8IcZPlFo31HKzPDwC5ykz/cUZ/Av/cMXPYL+86DyAWa8q/ioe1FqaoQ+ NcGul8NTpG+Hm6bd49cktHQNPQp6oFrSoJhCL5O0kMGE1rIIY33mszWmdA/22iOrYV v76HuHH6XLTPYF08s+u0FpIDneCN2buVErQWFb8rYDgvi/s0+YqGSzBTUvul9Z3nki jzVF1BKIYLumAsWqMMU85vp8Ry/KBYBDWaJout0cHcFPMq0yfH2Uq2CZQsLZ04WU6C NyLgD6S1MLTgxSe5EsmyZqfFlhroGwR8T0GF4YkvSMr6k6Y4jKe24v6/8T8inIDIpa L4eIwO6CFg3xQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jessica Zhang , Maxime Ripard , Dmitry Baryshkov , Sasha Levin , maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.15 153/153] drm: Add valid clones check Date: Mon, 5 May 2025 19:13:20 -0400 Message-Id: <20250505231320.2695319-153-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505231320.2695319-1-sashal@kernel.org> References: <20250505231320.2695319-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.181 Content-Transfer-Encoding: 8bit From: Jessica Zhang [ Upstream commit 41b4b11da02157c7474caf41d56baae0e941d01a ] Check that all encoders attached to a given CRTC are valid possible_clones of each other. Signed-off-by: Jessica Zhang Reviewed-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20241216-concurrent-wb-v4-3-fe220297a7f0@quicinc.com Signed-off-by: Dmitry Baryshkov Signed-off-by: Sasha Levin --- drivers/gpu/drm/drm_atomic_helper.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index bd01d925769db..db3c58013c00d 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -563,6 +563,30 @@ mode_valid(struct drm_atomic_state *state) return 0; } +static int drm_atomic_check_valid_clones(struct drm_atomic_state *state, + struct drm_crtc *crtc) +{ + struct drm_encoder *drm_enc; + struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state, + crtc); + + drm_for_each_encoder_mask(drm_enc, crtc->dev, crtc_state->encoder_mask) { + if (!drm_enc->possible_clones) { + DRM_DEBUG("enc%d possible_clones is 0\n", drm_enc->base.id); + continue; + } + + if ((crtc_state->encoder_mask & drm_enc->possible_clones) != + crtc_state->encoder_mask) { + DRM_DEBUG("crtc%d failed valid clone check for mask 0x%x\n", + crtc->base.id, crtc_state->encoder_mask); + return -EINVAL; + } + } + + return 0; +} + /** * drm_atomic_helper_check_modeset - validate state object for modeset changes * @dev: DRM device @@ -729,6 +753,10 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, ret = drm_atomic_add_affected_planes(state, crtc); if (ret != 0) return ret; + + ret = drm_atomic_check_valid_clones(state, crtc); + if (ret != 0) + return ret; } /* -- 2.39.5