From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D97FB2F4961; Mon, 5 May 2025 23:16:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746486973; cv=none; b=YF5jjxhtYEJDEMDjfIXjqt16ecfVwiiLFhKjjRc2VVKKvptL32mAuoKSPlfLuXaJOwovkWlmNLG+2yBdT2GrLsgjH9kmx2JrBSABgCqDa1Qm7oxgMMwAO8Tpq66o9hzvDxJjCC1UcYdGtq7VjW5HpCHnYGxsz8bJDjgHjmrrrG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746486973; c=relaxed/simple; bh=VoYrOWSuePqP7lmw5BS5TP9vhr4zHmMkmvDx4QLVzKI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ePHzQ5akINYI3b+vRGZtJS6XUWjr5DjBFklBX+W6oHUNV/f7jJdr52kJ0CNJTdb1y7jA3p4HR3sAHRROJwoS5NQQk8wWl9zLzfLbqUGllHIJZGDjxnbFylqWrV9Tk6gjj71Sl9qUky8RgrY3GOr3jPGJX4EoAM3CaW+bUMorQWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Kl6/ndAY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kl6/ndAY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FE5BC4CEE4; Mon, 5 May 2025 23:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746486973; bh=VoYrOWSuePqP7lmw5BS5TP9vhr4zHmMkmvDx4QLVzKI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kl6/ndAYzr0I1XyCrLwJEV/bDmbjFNImAUlyobamUKUqCKlI2X6EXaB6AFCr93Rof DTHMSkKLiUF0VxI9T7lsVqUkEo5cjAVsoqZHpQzB8CB7Q7ZKD2i1pSmG0L529dj+8z OLc5ngy5Ue8fKFFHzGWs2N13eGaPz8QjzxyqfCiKcT5m0vG7uCk6YdnM4YMbOOQ3YD EvTDIqgAjVPVHjCrAflXy+j6vGFrcKa1Jy0lIie8pR5yJDfK2pgyZYtiKn3hioOQxO bJqJrE2XYLm0Mk/iYOqFBpInbfso/ZxGp0VlEP7XK6d4uoJ34S1HaF0n0hnPSW5QBv wkhOyEPVBnctA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nir Lichtman , Ingo Molnar , "H. Peter Anvin" , Ard Biesheuvel , Masahiro Yamada , Michal Marek , Sasha Levin , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org Subject: [PATCH AUTOSEL 5.15 088/153] x86/build: Fix broken copy command in genimage.sh when making isoimage Date: Mon, 5 May 2025 19:12:15 -0400 Message-Id: <20250505231320.2695319-88-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505231320.2695319-1-sashal@kernel.org> References: <20250505231320.2695319-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.181 Content-Transfer-Encoding: 8bit From: Nir Lichtman [ Upstream commit e451630226bd09dc730eedb4e32cab1cc7155ae8 ] Problem: Currently when running the "make isoimage" command there is an error related to wrong parameters passed to the cp command: "cp: missing destination file operand after 'arch/x86/boot/isoimage/'" This is caused because FDINITRDS is an empty array. Solution: Check if FDINITRDS is empty before executing the "cp" command, similar to how it is done in the case of hdimage. Signed-off-by: Nir Lichtman Signed-off-by: Ingo Molnar Cc: "H. Peter Anvin" Cc: Ard Biesheuvel Cc: Masahiro Yamada Cc: Michal Marek Link: https://lore.kernel.org/r/20250110120500.GA923218@lichtman.org Signed-off-by: Sasha Levin --- arch/x86/boot/genimage.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/boot/genimage.sh b/arch/x86/boot/genimage.sh index 0673fdfc1a11a..a8a9b1daffac8 100644 --- a/arch/x86/boot/genimage.sh +++ b/arch/x86/boot/genimage.sh @@ -22,6 +22,7 @@ # This script requires: # bash # syslinux +# genisoimage # mtools (for fdimage* and hdimage) # edk2/OVMF (for hdimage) # @@ -250,7 +251,9 @@ geniso() { cp "$isolinux" "$ldlinux" "$tmp_dir" cp "$FBZIMAGE" "$tmp_dir"/linux echo default linux "$KCMDLINE" > "$tmp_dir"/isolinux.cfg - cp "${FDINITRDS[@]}" "$tmp_dir"/ + if [ ${#FDINITRDS[@]} -gt 0 ]; then + cp "${FDINITRDS[@]}" "$tmp_dir"/ + fi genisoimage -J -r -appid 'LINUX_BOOT' -input-charset=utf-8 \ -quiet -o "$FIMAGE" -b isolinux.bin \ -c boot.cat -no-emul-boot -boot-load-size 4 \ -- 2.39.5