From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAD053BB6B6; Mon, 5 May 2025 23:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487359; cv=none; b=o+IqpOQf5mcN/C05Oh8yHYyRQ3QHIEfsSSiz6ulpEaKTsyis7Kik36Feke2n/6io2r8uxGoLGPTPtnxSn6lTg2V+KjNCmH2ZI00NPhwTOdPJGyKoawnDPtRsluvF160vCXz7I6gyyHfT3K6qoWUv7785WADLQ67fRLMpjkM/OJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487359; c=relaxed/simple; bh=qnEKhE/uU6APP+KlY0+51pC2imB0DVcSaADx09MWxiA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZrcoIPA6zk3/LJzeqnMH8EYqfNXBz7PL2U0Au3yzTW6rsk57LjiF2kpJP7ucQegiqsJPlmJJ9w/QlD75BHq/lFBM/hJa2Rq8n1zurjG0StdcDkc3EUH+VhOcSLTar+EPOvmoqHbLMnw0YOPkTFyaj69LJ2GtVT03AndtGAkp/eI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=plw+gtMj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="plw+gtMj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 036BEC4CEED; Mon, 5 May 2025 23:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746487358; bh=qnEKhE/uU6APP+KlY0+51pC2imB0DVcSaADx09MWxiA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=plw+gtMjMEaQhpfEu8m2NNjOWEoBOtYqzIRHCzlvs5F41WYws7E9DzHxMmgnzAdVU Y80dFaQfLO0TlPxAyd45EqhumdXrdZ6SBnbKIk32ImSjDuU5MwTQLg4Y0fS3B1Tb/n cztr/C2skmyHRaj+1s7xwTVQsjd7iI8qen6hykLM8D+9T2/Zwd+7nQ/dXrFUIa49/Y y7PmBVSpSjjZMXmpGDujqZmhPSf8I5W2Hi9PUMnCGuOH+wwfY3POUGcpZF9zsfkVzb or5iiaeQCfT1vMZffMDUgLt4Khr4EtmJtmVcxX6Sgcr5jGTN14E5F3DAM2Q/mqBiTG rGazd9c2bjwRA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexandre Belloni , Sasha Levin , linux-rtc@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 28/79] rtc: ds1307: stop disabling alarms on probe Date: Mon, 5 May 2025 19:21:00 -0400 Message-Id: <20250505232151.2698893-28-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505232151.2698893-1-sashal@kernel.org> References: <20250505232151.2698893-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.293 Content-Transfer-Encoding: 8bit From: Alexandre Belloni [ Upstream commit dcec12617ee61beed928e889607bf37e145bf86b ] It is a bad practice to disable alarms on probe or remove as this will prevent alarms across reboots. Link: https://lore.kernel.org/r/20250303223744.1135672-1-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-ds1307.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 99b93f56a2d50..40532a36ae67c 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -1680,10 +1680,8 @@ static int ds1307_probe(struct i2c_client *client, * For some variants, be sure alarms can trigger when we're * running on Vbackup (BBSQI/BBSQW) */ - if (want_irq || ds1307_can_wakeup_device) { + if (want_irq || ds1307_can_wakeup_device) regs[0] |= DS1337_BIT_INTCN | chip->bbsqi_bit; - regs[0] &= ~(DS1337_BIT_A2IE | DS1337_BIT_A1IE); - } regmap_write(ds1307->regmap, DS1337_REG_CONTROL, regs[0]); -- 2.39.5