From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 847EE2FAEBC; Mon, 5 May 2025 23:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487387; cv=none; b=cH9KM1bR+2gcRXLCoupl9HFwvDCac0FSJqoXXjI/YDyCDnfVK2S9r8tqsmNqAVphdHFnWUS6mDaw++owJVj2DGentsTHL3iPIqGIx1Xz/CGs18AzWLXceFTtw/YjozxRLLzNhunEgjFszXR5xvHoiWTZdqQQr4Qmt+w9W3YnM6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487387; c=relaxed/simple; bh=PUoU3kFI4BLvkins4qhJssnKl2gATCFExsBo1yCK+EA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X7lX9/4lqoyDxbs/po7/u1v+kGAV7PxXP5/hB7p+r5EvnP8iX1uYdSgtL8ezwEOzuaQzktIKI3VYUKv6eN1pnT8+lucn255DhuNoh2R+U3YcmkGxXy01h0iCCNkfvnijEC1WQrSU0plOAVikJ7xpQUFdrabQzHpgABf/fZM8PTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j7KJM8xZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j7KJM8xZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F522C4CEE4; Mon, 5 May 2025 23:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746487386; bh=PUoU3kFI4BLvkins4qhJssnKl2gATCFExsBo1yCK+EA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j7KJM8xZwJ/UnxXphfZgwKRAj7VVBv1ZcqSUuKBufVSRXrFOjR/4X/1SSK21WZRVj 3K20kvqSTMr4pE23GDUtILM18Rpb9Mq+oVQPN2BffkjooCmlnK+CoASoJMd42UPc8o aGaJu84UUz+R6YIxY17q50dq6AZJ0TjPNkW66o6xGdqHrMmdDe8sPoh+dxR8Fr+krJ ng5kaYfKsLjAe/uVSUPtGRbNgvgh5sKzgbm8ip6D4oD5igB1LG/Q4L4hFtlVh7mBmO 1wHo8AeR0ESr/vrtzbwnM2viWLxRd3faEpAPowWj4/lMgIlP3aMxMKFCfRfEIim2pW K8jFRkro1IWiQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Philip Yang , Felix Kuehling , Alex Deucher , Sasha Levin , Felix.Kuehling@amd.com, christian.koenig@amd.com, airlied@gmail.com, simona@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.4 42/79] drm/amdkfd: KFD release_work possible circular locking Date: Mon, 5 May 2025 19:21:14 -0400 Message-Id: <20250505232151.2698893-42-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505232151.2698893-1-sashal@kernel.org> References: <20250505232151.2698893-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.293 Content-Transfer-Encoding: 8bit From: Philip Yang [ Upstream commit 1b9366c601039d60546794c63fbb83ce8e53b978 ] If waiting for gpu reset done in KFD release_work, thers is WARNING: possible circular locking dependency detected #2 kfd_create_process kfd_process_mutex flush kfd release work #1 kfd release work wait for amdgpu reset work #0 amdgpu_device_gpu_reset kgd2kfd_pre_reset kfd_process_mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock((work_completion)(&p->release_work)); lock((wq_completion)kfd_process_wq); lock((work_completion)(&p->release_work)); lock((wq_completion)amdgpu-reset-dev); To fix this, KFD create process move flush release work outside kfd_process_mutex. Signed-off-by: Philip Yang Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c index 662e4d973f13a..b07deeb987475 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c @@ -277,6 +277,14 @@ struct kfd_process *kfd_create_process(struct file *filep) if (thread->group_leader->mm != thread->mm) return ERR_PTR(-EINVAL); + /* If the process just called exec(3), it is possible that the + * cleanup of the kfd_process (following the release of the mm + * of the old process image) is still in the cleanup work queue. + * Make sure to drain any job before trying to recreate any + * resource for this process. + */ + flush_workqueue(kfd_process_wq); + /* * take kfd processes mutex before starting of process creation * so there won't be a case where two threads of the same process @@ -289,14 +297,6 @@ struct kfd_process *kfd_create_process(struct file *filep) if (process) { pr_debug("Process already found\n"); } else { - /* If the process just called exec(3), it is possible that the - * cleanup of the kfd_process (following the release of the mm - * of the old process image) is still in the cleanup work queue. - * Make sure to drain any job before trying to recreate any - * resource for this process. - */ - flush_workqueue(kfd_process_wq); - process = create_process(thread); if (IS_ERR(process)) goto out; -- 2.39.5