From: Alexey Charkov <alchark@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Alexey Charkov <alchark@gmail.com>
Subject: [PATCH v2 2/5] irqchip/irq-vt8500: Drop redundant copy of the device node pointer
Date: Tue, 06 May 2025 16:46:15 +0400 [thread overview]
Message-ID: <20250506-vt8500-intc-updates-v2-2-a3a0606cf92d@gmail.com> (raw)
In-Reply-To: <20250506-vt8500-intc-updates-v2-0-a3a0606cf92d@gmail.com>
Inside vt8500_irq_init, np is the same as node. Drop it.
Signed-off-by: Alexey Charkov <alchark@gmail.com>
---
drivers/irqchip/irq-vt8500.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/irqchip/irq-vt8500.c b/drivers/irqchip/irq-vt8500.c
index d0580f6577c88ffd7e374d640418d1fc23db623e..6d46e1a0fda953d76679ad2318674fdf0a977f0b 100644
--- a/drivers/irqchip/irq-vt8500.c
+++ b/drivers/irqchip/irq-vt8500.c
@@ -191,7 +191,6 @@ static int __init vt8500_irq_init(struct device_node *node,
struct device_node *parent)
{
int irq, i;
- struct device_node *np = node;
if (active_cnt == VT8500_INTC_MAX) {
pr_err("%s: Interrupt controllers > VT8500_INTC_MAX\n",
@@ -199,7 +198,7 @@ static int __init vt8500_irq_init(struct device_node *node,
goto out;
}
- intc[active_cnt].base = of_iomap(np, 0);
+ intc[active_cnt].base = of_iomap(node, 0);
intc[active_cnt].domain = irq_domain_add_linear(node, 64,
&vt8500_irq_domain_ops, &intc[active_cnt]);
@@ -222,16 +221,16 @@ static int __init vt8500_irq_init(struct device_node *node,
active_cnt++;
/* check if this is a slaved controller */
- if (of_irq_count(np) != 0) {
+ if (of_irq_count(node) != 0) {
/* check that we have the correct number of interrupts */
- if (of_irq_count(np) != 8) {
+ if (of_irq_count(node) != 8) {
pr_err("%s: Incorrect IRQ map for slaved controller\n",
__func__);
return -EINVAL;
}
for (i = 0; i < 8; i++) {
- irq = irq_of_parse_and_map(np, i);
+ irq = irq_of_parse_and_map(node, i);
enable_irq(irq);
}
--
2.49.0
next prev parent reply other threads:[~2025-05-06 12:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 12:46 [PATCH v2 0/5] irqchip/irq-vt8500: Cleanups and fixes for the irq-vt8500 driver Alexey Charkov
2025-05-06 12:46 ` [PATCH v2 1/5] irqchip/irq-vt8500: Split up ack/mask functions Alexey Charkov
2025-05-06 14:04 ` [tip: irq/drivers] " tip-bot2 for Alexey Charkov
2025-05-06 12:46 ` Alexey Charkov [this message]
2025-05-06 14:04 ` [tip: irq/drivers] irqchip/irq-vt8500: Drop redundant copy of the device node pointer tip-bot2 for Alexey Charkov
2025-05-06 12:46 ` [PATCH v2 3/5] irqchip/irq-vt8500: Don't require 8 interrupts from a chained controller Alexey Charkov
2025-05-06 14:04 ` [tip: irq/drivers] " tip-bot2 for Alexey Charkov
2025-05-06 12:46 ` [PATCH v2 4/5] irqchip/irq-vt8500: Use a dedicated chained handler function Alexey Charkov
2025-05-06 14:04 ` [tip: irq/drivers] " tip-bot2 for Alexey Charkov
2025-05-06 12:46 ` [PATCH v2 5/5] irqchip/irq-vt8500: Use fewer global variables and add error handling Alexey Charkov
2025-05-06 14:04 ` [tip: irq/drivers] " tip-bot2 for Alexey Charkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250506-vt8500-intc-updates-v2-2-a3a0606cf92d@gmail.com \
--to=alchark@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®