mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: brauner@kernel.org, djwong@kernel.org, hch@lst.de,
	viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org
Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com,
	linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	ojaswin@linux.ibm.com, ritesh.list@gmail.com,
	martin.petersen@oracle.com, linux-ext4@vger.kernel.org,
	linux-block@vger.kernel.org, catherine.hoang@oracle.com,
	linux-api@vger.kernel.org, John Garry <john.g.garry@oracle.com>
Subject: [PATCH v12 03/17] xfs: rename xfs_inode_can_atomicwrite() -> xfs_inode_can_hw_atomic_write()
Date: Tue,  6 May 2025 09:04:13 +0000	[thread overview]
Message-ID: <20250506090427.2549456-4-john.g.garry@oracle.com> (raw)
In-Reply-To: <20250506090427.2549456-1-john.g.garry@oracle.com>

In future we will want to be able to check if specifically HW offload-based
atomic writes are possible, so rename xfs_inode_can_atomicwrite() ->
xfs_inode_can_hw_atomicwrite().

Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
[djwong: add an underscore to be consistent with everything else]
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 fs/xfs/xfs_file.c  | 2 +-
 fs/xfs/xfs_inode.h | 4 +---
 fs/xfs/xfs_iops.c  | 2 +-
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 84f08c976ac4..55bdae44e42a 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -1488,7 +1488,7 @@ xfs_file_open(
 	if (xfs_is_shutdown(XFS_M(inode->i_sb)))
 		return -EIO;
 	file->f_mode |= FMODE_NOWAIT | FMODE_CAN_ODIRECT;
-	if (xfs_inode_can_atomicwrite(XFS_I(inode)))
+	if (xfs_inode_can_hw_atomic_write(XFS_I(inode)))
 		file->f_mode |= FMODE_CAN_ATOMIC_WRITE;
 	return generic_file_open(inode, file);
 }
diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
index eae0159983ca..d3471a7418b9 100644
--- a/fs/xfs/xfs_inode.h
+++ b/fs/xfs/xfs_inode.h
@@ -356,9 +356,7 @@ static inline bool xfs_inode_has_bigrtalloc(const struct xfs_inode *ip)
 	(XFS_IS_REALTIME_INODE(ip) ? \
 		(ip)->i_mount->m_rtdev_targp : (ip)->i_mount->m_ddev_targp)
 
-static inline bool
-xfs_inode_can_atomicwrite(
-	struct xfs_inode	*ip)
+static inline bool xfs_inode_can_hw_atomic_write(const struct xfs_inode *ip)
 {
 	struct xfs_mount	*mp = ip->i_mount;
 	struct xfs_buftarg	*target = xfs_inode_buftarg(ip);
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index f0e5d83195df..22432c300fd7 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -608,7 +608,7 @@ xfs_report_atomic_write(
 {
 	unsigned int		unit_min = 0, unit_max = 0;
 
-	if (xfs_inode_can_atomicwrite(ip))
+	if (xfs_inode_can_hw_atomic_write(ip))
 		unit_min = unit_max = ip->i_mount->m_sb.sb_blocksize;
 	generic_fill_statx_atomic_writes(stat, unit_min, unit_max, 0);
 }
-- 
2.31.1


  parent reply	other threads:[~2025-05-06  9:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06  9:04 [PATCH v12 00/17] large atomic writes for xfs John Garry
2025-05-06  9:04 ` [PATCH v12 01/17] fs: add atomic write unit max opt to statx John Garry
2025-05-06  9:04 ` [PATCH v12 02/17] xfs: only call xfs_setsize_buftarg once per buffer target John Garry
2025-05-06 12:00   ` Christoph Hellwig
2025-05-06  9:04 ` John Garry [this message]
2025-05-06  9:04 ` [PATCH v12 04/17] xfs: separate out setting buftarg atomic writes limits John Garry
2025-05-06  9:04 ` [PATCH v12 05/17] xfs: add helpers to compute log item overhead John Garry
2025-05-06  9:04 ` [PATCH v12 06/17] xfs: add helpers to compute transaction reservation for finishing intent items John Garry
2025-05-06  9:04 ` [PATCH v12 07/17] xfs: ignore HW which cannot atomic write a single block John Garry
2025-05-06  9:04 ` [PATCH v12 08/17] xfs: allow block allocator to take an alignment hint John Garry
2025-05-06  9:04 ` [PATCH v12 09/17] xfs: refactor xfs_reflink_end_cow_extent() John Garry
2025-05-06  9:04 ` [PATCH v12 10/17] xfs: refine atomic write size check in xfs_file_write_iter() John Garry
2025-05-06  9:04 ` [PATCH v12 11/17] xfs: add xfs_atomic_write_cow_iomap_begin() John Garry
2025-05-06  9:04 ` [PATCH v12 12/17] xfs: add large atomic writes checks in xfs_direct_write_iomap_begin() John Garry
2025-05-06  9:04 ` [PATCH v12 13/17] xfs: commit CoW-based atomic writes atomically John Garry
2025-05-06  9:04 ` [PATCH v12 14/17] xfs: add xfs_file_dio_write_atomic() John Garry
2025-05-06  9:04 ` [PATCH v12 15/17] xfs: add xfs_calc_atomic_write_unit_max() John Garry
2025-05-06  9:04 ` [PATCH v12 16/17] xfs: update atomic write limits John Garry
2025-05-06  9:04 ` [PATCH v12 17/17] xfs: allow sysadmins to specify a maximum atomic write limit at mount time John Garry
2025-05-07 15:14   ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250506090427.2549456-4-john.g.garry@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=brauner@kernel.org \
    --cc=catherine.hoang@oracle.com \
    --cc=cem@kernel.org \
    --cc=dchinner@redhat.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ojaswin@linux.ibm.com \
    --cc=ritesh.list@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®