From: Leo Yan <leo.yan@arm.com>
To: James Clark <james.clark@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Yeoreum Yun <yeoreum.yun@arm.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight: replicator: Fix panic for clearing claim tag
Date: Tue, 6 May 2025 10:57:16 +0100 [thread overview]
Message-ID: <20250506095716.GC177796@e132581.arm.com> (raw)
In-Reply-To: <6f9346a0-03c5-4b00-85f9-0d54e24d0657@linaro.org>
On Tue, May 06, 2025 at 10:27:37AM +0100, James Clark wrote:
[...]
> > @@ -262,6 +262,7 @@ static int replicator_probe(struct device *dev, struct resource *res)
> > drvdata->base = base;
> > desc.groups = replicator_groups;
> > desc.access = CSDEV_ACCESS_IOMEM(base);
> > + coresight_clear_self_claim_tag(&desc.access);
> > }
> > if (fwnode_property_present(dev_fwnode(dev),
> > @@ -284,7 +285,6 @@ static int replicator_probe(struct device *dev, struct resource *res)
> > desc.pdata = dev->platform_data;
> > desc.dev = dev;
> > - coresight_clear_self_claim_tag(&desc.access);
> > drvdata->csdev = coresight_register(&desc);
> > if (IS_ERR(drvdata->csdev)) {
> > ret = PTR_ERR(drvdata->csdev);
>
> Oops. The other occurrence of this is the funnel, but I got that one right.
>
> Reviewed-by: James Clark <james.clark@linaro.org>
Thanks for review. Yes, the funnel driver is fine as it accesses claim
tag for only MMIO mode.
Leo
next prev parent reply other threads:[~2025-05-06 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 11:11 Leo Yan
2025-05-06 9:27 ` James Clark
2025-05-06 9:57 ` Leo Yan [this message]
2025-05-06 11:05 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250506095716.GC177796@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®