Re: [PATCH v4 3/3] clk: add TI CDCE6214 clock driver

[kernel test robot <lkp@intel.com>]

Hi Sascha,

kernel test robot noticed the following build errors:

[auto build test ERROR on 0af2f6be1b4281385b618cb86ad946eded089ac8]

url:    https://github.com/intel-lab-lkp/linux/commits/Sascha-Hauer/clk-make-determine_rate-optional-for-non-reparenting-clocks/20250430-170445
base:   0af2f6be1b4281385b618cb86ad946eded089ac8
patch link:    https://lore.kernel.org/r/20250430-clk-cdce6214-v4-3-9f15e7126ac6%40pengutronix.de
patch subject: [PATCH v4 3/3] clk: add TI CDCE6214 clock driver
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20250507/202505071411.GB5uyv3w-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250507/202505071411.GB5uyv3w-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505071411.GB5uyv3w-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/clk/clk-cdce6214.c:319:7: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     319 |                            FIELD_PREP(R2_REFSEL_SW, 2));
         |                            ^
>> drivers/clk/clk-cdce6214.c:333:8: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     333 |         div = FIELD_GET(R25_IP_RDIV, val);
         |               ^
   drivers/clk/clk-cdce6214.c:362:53: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     362 |                 regmap_update_bits(priv->regmap, 25, R25_IP_RDIV, FIELD_PREP(R25_IP_RDIV, 0));
         |                                                                   ^
   drivers/clk/clk-cdce6214.c:370:52: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     370 |         regmap_update_bits(priv->regmap, 25, R25_IP_RDIV, FIELD_PREP(R25_IP_RDIV, div));
         |                                                           ^
   drivers/clk/clk-cdce6214.c:383:8: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     383 |         idx = FIELD_GET(R2_REFSEL_SW, val);
         |               ^
   drivers/clk/clk-cdce6214.c:406:55: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     406 |         regmap_update_bits(priv->regmap, 25, R25_REF_CH_MUX, FIELD_PREP(R25_REF_CH_MUX, index));
         |                                                              ^
   drivers/clk/clk-cdce6214.c:480:9: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     480 |                 div = FIELD_GET(R56_CH1_DIV, val);
         |                       ^
   drivers/clk/clk-cdce6214.c:535:8: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     535 |                                    FIELD_PREP(R56_CH1_DIV, div));
         |                                    ^
   drivers/clk/clk-cdce6214.c:563:9: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     563 |                 idx = FIELD_GET(R56_CH1_MUX, val);
         |                       ^
   drivers/clk/clk-cdce6214.c:589:53: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     589 |                 regmap_update_bits(priv->regmap, 56, R56_CH1_MUX, FIELD_PREP(R56_CH1_MUX, index));
         |                                                                   ^
   drivers/clk/clk-cdce6214.c:643:9: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     643 |         ndiv = FIELD_GET(R30_PLL_NDIV, val);
         |                ^
   drivers/clk/clk-cdce6214.c:755:7: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     755 |                            FIELD_PREP(R34_PLL_DEN_23_16, den >> 16));
         |                            ^
   drivers/clk/clk-cdce6214.c:842:13: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     842 |                 div = psx[FIELD_GET(R47_PLL_PSA, val)];
         |                           ^
   drivers/clk/clk-cdce6214.c:883:8: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     883 |                                    FIELD_PREP(R47_PLL_PSA, div));
         |                                    ^
   drivers/clk/clk-cdce6214.c:998:7: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     998 |                            FIELD_PREP(R24_IP_XO_CLOAD, i));
         |                            ^
   15 errors generated.


vim +/FIELD_PREP +319 drivers/clk/clk-cdce6214.c

   315	
   316	static int cdce6214_configure(struct cdce6214 *priv)
   317	{
   318		regmap_update_bits(priv->regmap, 2, R2_REFSEL_SW,
 > 319				   FIELD_PREP(R2_REFSEL_SW, 2));
   320	
   321		return 0;
   322	}
   323	
   324	static unsigned long cdce6214_clk_out0_recalc_rate(struct clk_hw *hw,
   325							   unsigned long parent_rate)
   326	{
   327		struct cdce6214_clock *clock = hw_to_cdce6214_clk(hw);
   328		struct cdce6214 *priv = clock->priv;
   329		unsigned int val, div;
   330	
   331		regmap_read(priv->regmap, 25, &val);
   332	
 > 333		div = FIELD_GET(R25_IP_RDIV, val);
   334	
   335		if (!div)
   336			return parent_rate * 2;
   337	
   338		return DIV_ROUND_UP_ULL((u64)parent_rate, div);
   339	}
   340	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki