From: Steven Rostedt <rostedt@goodmis.org>
To: Paul Cacheux via B4 Relay <devnull+paulcacheux.gmail.com@kernel.org>
Cc: paulcacheux@gmail.com, Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] tracing: protect trace_probe_log with mutex
Date: Wed, 7 May 2025 17:29:17 -0400 [thread overview]
Message-ID: <20250507172917.0b4e3043@gandalf.local.home> (raw)
In-Reply-To: <20250504-fix-trace-probe-log-race-v3-2-9e99fec7eddc@gmail.com>
On Sun, 04 May 2025 20:27:53 +0200
Paul Cacheux via B4 Relay <devnull+paulcacheux.gmail.com@kernel.org> wrote:
> From: Paul Cacheux <paulcacheux@gmail.com>
>
> The shared trace_probe_log variable can be accessed and modified
> by multiple processes using tracefs at the same time, this new
> mutex will guarantee it's always in a coherent state.
>
> There is no guarantee that multiple errors happening at the same
> time will each have the correct error message, but at least this
> won't crash.
>
> Fixes: ab105a4fb894 ("tracing: Use tracing error_log with probe events")
> Signed-off-by: Paul Cacheux <paulcacheux@gmail.com>
> ---
> kernel/trace/trace_probe.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2025-05-07 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-04 18:27 [PATCH v3 0/2] tracing: fix race when creating trace probe log error message Paul Cacheux via B4 Relay
2025-05-04 18:27 ` [PATCH v3 1/2] tracing: add missing trace_probe_log_clear for eprobes Paul Cacheux via B4 Relay
2025-05-07 21:31 ` Steven Rostedt
2025-05-04 18:27 ` [PATCH v3 2/2] tracing: protect trace_probe_log with mutex Paul Cacheux via B4 Relay
2025-05-07 21:29 ` Steven Rostedt [this message]
2025-05-07 21:33 ` [PATCH v3 0/2] tracing: fix race when creating trace probe log error message Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507172917.0b4e3043@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=devnull+paulcacheux.gmail.com@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulcacheux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®