From: Borislav Petkov <bp@alien8.de>
To: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Bernhard Kaindl <bk@suse.de>, Andi Kleen <ak@linux.intel.com>,
Li Fei <fei1.li@intel.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/mtrr: Check if fixed-range MTRR exists in mtrr_save_fixed_ranges()
Date: Fri, 9 May 2025 19:32:25 +0200 [thread overview]
Message-ID: <20250509173225.GDaB48KZvZSA9QLUaR@fat_crate.local> (raw)
In-Reply-To: <20250509170633.3411169-2-jiaqing.zhao@linux.intel.com>
On Fri, May 09, 2025 at 05:06:33PM +0000, Jiaqing Zhao wrote:
> When suspending, save_processor_state() calls mtrr_save_fixed_ranges()
> to save fixed-range MTRRs. On platforms without fixed-range MTRRs,
> accessing these MSRs will trigger unchecked MSR access error. Make
> sure fixed-range MTRRs are supported before access to prevent such
> error.
>
> Since mtrr_state.have_fixed is only set when MTRRs are present and
> enabled, checking the CPU feature flag in mtrr_save_fixed_ranges()
> is unnecessary.
>
> Fixes: 3ebad5905609 ("[PATCH] x86: Save and restore the fixed-range MTRRs of the BSP when suspending")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
Next question: this is CC:stable, meaning it'll go to Linus now.
What exactly is it fixing?
Because the patch in Fixes: is from 2007. :-\
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2025-05-09 17:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 17:06 Jiaqing Zhao
2025-05-09 17:32 ` Borislav Petkov [this message]
2025-05-12 8:31 ` Jiaqing Zhao
2025-05-12 8:46 ` Borislav Petkov
2025-05-12 9:24 ` Jiaqing Zhao
2025-05-12 11:00 ` Borislav Petkov
2025-05-12 14:31 ` [tip: x86/mtrr] x86/mtrr: Check if fixed-range MTRRs exist " tip-bot2 for Jiaqing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250509173225.GDaB48KZvZSA9QLUaR@fat_crate.local \
--to=bp@alien8.de \
--cc=ak@linux.intel.com \
--cc=bk@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=fei1.li@intel.com \
--cc=hpa@zytor.com \
--cc=jiaqing.zhao@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®