From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andrew Ijano <andrew.ijano@gmail.com>,
andrew.lopes@alumni.usp.br, gustavobastos@usp.br,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
jstephan@baylibre.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] iio: accel: sca3000: replace usages of internal read data helpers by spi helpers
Date: Sun, 11 May 2025 12:35:24 +0100 [thread overview]
Message-ID: <20250511123524.3975201d@jic23-huawei> (raw)
In-Reply-To: <CAHp75Ve7-hMUxrmXQnkMjynhPUbD6R+K=-j+h0zELvcxZdy5nw@mail.gmail.com>
> ...
>
> > - *val = sign_extend32(be16_to_cpup((__be16 *)st->rx) >>
> > + *val = sign_extend32(be16_to_cpu((__be16) ret) >>
>
> This doesn't look good, can you define a proper __be16 variable on
> stack and use it instead of ret?
As I mention in v4 quick review, we have spi_w8r16be() to avoid the need
to have this dance at all.
>
next prev parent reply other threads:[~2025-05-11 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 1:38 Andrew Ijano
2025-05-09 9:06 ` Andy Shevchenko
2025-05-11 11:35 ` Jonathan Cameron [this message]
2025-05-11 17:23 ` Andrew Ijano
2025-05-09 22:58 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250511123524.3975201d@jic23-huawei \
--to=jic23@kernel.org \
--cc=andrew.ijano@gmail.com \
--cc=andrew.lopes@alumni.usp.br \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavobastos@usp.br \
--cc=jstephan@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®