From: Chao Yu <chao@kernel.org>
To: jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Chao Yu <chao@kernel.org>
Subject: [PATCH 2/2] f2fs: add f2fs_bug_on() in f2fs_quota_read()
Date: Mon, 12 May 2025 19:54:42 +0800 [thread overview]
Message-ID: <20250512115442.2640895-2-chao@kernel.org> (raw)
In-Reply-To: <20250512115442.2640895-1-chao@kernel.org>
mapping_read_folio_gfp() will return a folio, it should always be
uptodate, let's check folio uptodate status to detect any potenial
bug.
Signed-off-by: Chao Yu <chao@kernel.org>
---
fs/f2fs/super.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 0ee783224953..ea207a9edc10 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2973,6 +2973,17 @@ static ssize_t f2fs_quota_read(struct super_block *sb, int type, char *data,
goto repeat;
}
+ /*
+ * should never happen, just leave f2fs_bug_on() here to catch
+ * any potential bug.
+ */
+ if (unlikely(!folio_test_uptodate(folio))) {
+ f2fs_folio_put(folio, true);
+ set_sbi_flag(F2FS_SB(sb), SBI_QUOTA_NEED_REPAIR);
+ f2fs_bug_on(F2FS_SB(sb), 1);
+ return -EIO;
+ }
+
memcpy_from_folio(data, folio, offset, tocopy);
f2fs_folio_put(folio, true);
--
2.49.0
next prev parent reply other threads:[~2025-05-12 11:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 11:54 [PATCH 1/2] f2fs: add f2fs_bug_on() to detect potential bug Chao Yu
2025-05-12 11:54 ` Chao Yu [this message]
2025-05-12 15:27 ` [PATCH 2/2] f2fs: add f2fs_bug_on() in f2fs_quota_read() Jaegeuk Kim
2025-05-13 2:45 ` Chao Yu
2025-05-12 15:26 ` [PATCH 1/2] f2fs: add f2fs_bug_on() to detect potential bug Jaegeuk Kim
2025-05-13 2:44 ` Chao Yu
2025-05-14 15:40 ` [f2fs-dev] " patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512115442.2640895-2-chao@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome