From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C4C8257AFD for ; Mon, 12 May 2025 12:34:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747053273; cv=none; b=QliGBEB+fqohEl/SSw33nrhEQqodv78myBs4zJo3NlZGQyvr78jvJfZtPtmfkQ3sSGPBfi5C2fottGrEQ6LWCDBJb+jKsbVYXxOP8/aW9fIyOrO0SMqkootPzea4DGH/aGlXmCwd3Sa+nVgjED1raZpSZAp3vm4zKCJUBA+HHRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747053273; c=relaxed/simple; bh=NX/Y/HVo0p4VYeB1ou1uSmIImGtgXg7WsYvl1qcXgCc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hVVp+vL5Mbc0AeNmzVHc4IS96tkBFHHP4yAh8oeJA/qxqXxa39iD0URPDcon4lLZjSuid3oA0iRem7MS2VX5dryOTCWYE/L52aWQbrGzPH2IoMnbwF6OBeir1yyqo8wJoBRpp0K8h9EoSyg2DjUronbfGqGiOwbfoD63i+6y1SE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SDbMxoNw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SDbMxoNw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747053269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=AsNfuXk++hQsXcSMH0/ZpoD/Dq28xwSeg936k+p2z/0=; b=SDbMxoNwDTWokoGQEf0vaBIl0qw/+Vo8NWWPMLvVzxGi3eIYaw+CkcpR47bNtRHVqaEzed xemdxT88eCW+M4mx96rqGmjKK257EFT1baAhPADDY2pYHaKLk12tFcwSbwiCoco9dAGbhP x7wYcFpHLFdjDfKCvfIhNcitr06fxwE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-76-UkzrGQWFMhun3ZSjROGQlQ-1; Mon, 12 May 2025 08:34:28 -0400 X-MC-Unique: UkzrGQWFMhun3ZSjROGQlQ-1 X-Mimecast-MFC-AGG-ID: UkzrGQWFMhun3ZSjROGQlQ_1747053267 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a2046b5e75so363829f8f.1 for ; Mon, 12 May 2025 05:34:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747053267; x=1747658067; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AsNfuXk++hQsXcSMH0/ZpoD/Dq28xwSeg936k+p2z/0=; b=WZWNeiAOgeronGq9XkaR0aYnouXZy6JaNTyIthtF6B1U8q1x9jLuOS97SqIg/xw5z2 GQPS2UhwnnYKdN9l//Yf6zMgdtrBzUv3KFiqO0FCFDoyjOXvhkCDHKXMLNzMSRWELflt IWCT36ATWagCxmfDF3TGyKBJsnZQODmeFqaLktG3jPiOKPjPTs03myz4hVBqftSOLbcX Y/Mmxb3hQuHqGqRjgoezMcKQJESeh2O98RaIYXCLCN/oEfR12E1CO5Zfm2cH/oVvzxLB wrYTRHUcR3GqR8oQ1ghHMkHlZccv1pZJ+kM69EqAakN1O5sQAj+f1blYCh7TiAKVirpm SY6g== X-Gm-Message-State: AOJu0YxIi4A450eKGl/jENrZGMEHp2lqG8ODGvQ0U7sGw+dW5PkjFq1r PYgzPNktkQRvYThUcrAqaUPedHBuZe+H9ZSknvhyy31QB1AtuT5+HRGAAnoHsDPob9yySqks2f0 0EPmtdaidh6gEJ1xxlLhg3CZ1ABAtstj+pIX5bz6D1pdCx6ioL3e4eKrRFri+LhH/s9cXKP6Ieo c4Lxez9PlqZmvXM+l/DjJ4WpSg/ZoYFFwGwURkXMwdf7ta X-Gm-Gg: ASbGncuzrR5Cuncg0ve2gr6HEv9gE85dcehuxu7qRE/viql5QAcWWRB23tQ/0eNOXo4 1U+XP6xb+kM0pRO70GD9Zk7MUwOknwKydjxoYp62kE04XMA8gn2cN8/qORSky6q85Tq+X8KOLd6 iVHyeHhGs2bOhVtjcbbJ+CaNiEfT8HLlt+AkhuXhkqfYXDpQ7ThLT/7EUdomKV97royY1wsjnkn bW58NgJM2p9YggXZw6E64WAwtrIrhEKT922eqRPqQeZ30KxwpVz2HrUqQ9HHjoNdNZyuH003bl3 HjbqsMeqhKqlny70TzzGpDAE7ugUWWKg1hLjFnTUNFsibTnwZYB/G243+ZWrytXCkaWbLtgD X-Received: by 2002:a05:6000:1a8a:b0:3a2:6bc:3f25 with SMTP id ffacd0b85a97d-3a206bc6568mr3282318f8f.36.1747053267196; Mon, 12 May 2025 05:34:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbVOvWh8aR7BY5sT0iHvCaoLmEQsNhObrlGdsawBm2VmjmvFE+wMDlxjPW6z9Q2DtavCs6CQ== X-Received: by 2002:a05:6000:1a8a:b0:3a2:6bc:3f25 with SMTP id ffacd0b85a97d-3a206bc6568mr3282274f8f.36.1747053266780; Mon, 12 May 2025 05:34:26 -0700 (PDT) Received: from localhost (p200300d82f4a5800f1ae8e20d7f451b0.dip0.t-ipconnect.de. [2003:d8:2f4a:5800:f1ae:8e20:d7f4:51b0]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a1f5a4c583sm12119696f8f.84.2025.05.12.05.34.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 May 2025 05:34:26 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, David Hildenbrand , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , Peter Xu Subject: [PATCH v2 00/11] mm: rewrite pfnmap tracking and remove VM_PAT Date: Mon, 12 May 2025 14:34:13 +0200 Message-ID: <20250512123424.637989-1-david@redhat.com> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On top of mm-unstable. VM_PAT annoyed me too much and wasted too much of my time, let's clean PAT handling up and remove VM_PAT. This should sort out various issues with VM_PAT we discovered recently, and will hopefully make the whole code more stable and easier to maintain. In essence: we stop letting PAT mode mess with VMAs and instead lift what to track/untrack to the MM core. We remember per VMA which pfn range we tracked in a new struct we attach to a VMA (we have space without exceeding 192 bytes), use a kref to share it among VMAs during split/mremap/fork, and automatically untrack once the kref drops to 0. This implies that we'll keep tracking a full pfn range even after partially unmapping it, until fully unmapping it; but as that case was mostly broken before, this at least makes it work in a way that is least intrusive to VMA handling. Shrinking with mremap() used to work in a hacky way, now we'll similarly keep the original pfn range tacked even after this form of partial unmap. Does anybody care about that? Unlikely. If we run into issues, we could likely handled that (adjust the tracking) when our kref drops to 1 while freeing a VMA. But it adds more complexity, so avoid that for now. Briefly tested with the new pfnmap selftests [1]. [1] https://lkml.kernel.org/r/20250509153033.952746-1-david@redhat.com Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Simona Vetter Cc: Andrew Morton Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Cc: "Liam R. Howlett" Cc: Lorenzo Stoakes Cc: Vlastimil Babka Cc: Jann Horn Cc: Pedro Falcato Cc: Peter Xu v1 -> v2: * "mm: convert track_pfn_insert() to pfnmap_setup_cachemode*()" -> Call it "pfnmap_setup_cachemode()" and improve the documentation -> Add pfnmap_setup_cachemode_pfn() -> Keep checking a single PFN for PMD/PUD case and document why it's ok * Merged memremap conversion patch with pfnmap_track() introduction patch -> Improve documentation * "mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()" -> Adjust to code changes in mm-unstable * Added "x86/mm/pat: inline memtype_match() into memtype_erase()" * "mm/io-mapping: track_pfn() -> "pfnmap tracking"" -> Adjust to code changes in mm-unstable David Hildenbrand (11): x86/mm/pat: factor out setting cachemode into pgprot_set_cachemode() mm: convert track_pfn_insert() to pfnmap_setup_cachemode*() mm: introduce pfnmap_track() and pfnmap_untrack() and use them for memremap mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack() x86/mm/pat: remove old pfnmap tracking interface mm: remove VM_PAT x86/mm/pat: remove strict_prot parameter from reserve_pfn_range() x86/mm/pat: remove MEMTYPE_*_MATCH x86/mm/pat: inline memtype_match() into memtype_erase() drm/i915: track_pfn() -> "pfnmap tracking" mm/io-mapping: track_pfn() -> "pfnmap tracking" arch/x86/mm/pat/memtype.c | 194 ++++------------------------- arch/x86/mm/pat/memtype_interval.c | 63 ++-------- drivers/gpu/drm/i915/i915_mm.c | 4 +- include/linux/mm.h | 4 +- include/linux/mm_inline.h | 2 + include/linux/mm_types.h | 11 ++ include/linux/pgtable.h | 127 ++++++++++--------- include/trace/events/mmflags.h | 4 +- mm/huge_memory.c | 5 +- mm/io-mapping.c | 2 +- mm/memory.c | 86 ++++++++++--- mm/memremap.c | 8 +- mm/mmap.c | 5 - mm/mremap.c | 4 - mm/vma_init.c | 50 ++++++++ 15 files changed, 242 insertions(+), 327 deletions(-) base-commit: c68cfbc5048ede4b10a1d3fe16f7f6192fc2c9c8 -- 2.49.0