mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: <jiang.kun2@zte.com.cn>
Cc: <bbonev@devuan.org>, <linux-kernel@vger.kernel.org>,
	<bsingharora@gmail.com>, <yang.yang29@zte.com.cn>,
	<wang.yaxin@zte.com.cn>, <xu.xin16@zte.com.cn>
Subject: Re: [PATCH linux next] taskstats: fix struct taskstats breaks backward  compatibility since version 15
Date: Mon, 12 May 2025 18:08:57 -0700	[thread overview]
Message-ID: <20250512180857.59e7836290cb72dad9f3b5d3@linux-foundation.org> (raw)
In-Reply-To: <20250510155413259V4JNRXxukdDgzsaL0Fo6a@zte.com.cn>

On Sat, 10 May 2025 15:54:13 +0800 (CST) <jiang.kun2@zte.com.cn> wrote:

> Problem
> ========
> commit 658eb5ab916d ("delayacct: add delay max to record
>  delay peak") - adding more fields
> commit f65c64f311ee ("delayacct: add delay min to record
>  delay peak") - adding more fields
> commit b016d0873777 ("taskstats: modify taskstats version")
>  - version bump to 15
> 
> Since version 15 (TASKSTATS_VERSION=15) the new layout of the
> structure adds fields in the middle of the structure, rendering
> all old software incompatible with newer kernels and software
> compiled against the new kernel headers incompatible with older
> kernels.
> 
> Solution
> =========
> move delay max and delay min to the end of taskstat, and bump
> the version to 16 after the change

Ah, there it it, thanks.

I'll add cc:stable to request a backport.  I'll also add

Fixes: 658eb5ab916d ("delayacct: add delay max to record delay peak")
Fixes: f65c64f311ee ("delayacct: add delay min to record delay peak")

which is odd, but gets the point across.  

The patch won't exactly apply to those kernels because the version
increment came later.  But I think that will be OK - the patch is
applicable to the v6.14 kernel.

  reply	other threads:[~2025-05-13  1:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-10  7:54 jiang.kun2
2025-05-13  1:08 ` Andrew Morton [this message]
2025-05-14  1:57 ` yang.yang29

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250512180857.59e7836290cb72dad9f3b5d3@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=bbonev@devuan.org \
    --cc=bsingharora@gmail.com \
    --cc=jiang.kun2@zte.com.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wang.yaxin@zte.com.cn \
    --cc=xu.xin16@zte.com.cn \
    --cc=yang.yang29@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®