From: Lee Trager <lee@trager.us>
To: Alexander Duyck <alexanderduyck@fb.com>,
Jakub Kicinski <kuba@kernel.org>,
kernel-team@meta.com, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Jacob Keller <jacob.e.keller@intel.com>,
Mohsin Bashir <mohsin.bashr@gmail.com>,
Sanman Pradhan <sanman.p211993@gmail.com>,
Su Hui <suhui@nfschina.com>, Lee Trager <lee@trager.us>,
Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next v5 0/5] eth: fbnic: Add devlink dev flash support
Date: Mon, 12 May 2025 11:53:56 -0700 [thread overview]
Message-ID: <20250512190109.2475614-1-lee@trager.us> (raw)
fbnic supports updating firmware using signed PLDM images. PLDM images are
written into the flash. Flashing does not interrupt the operation of the
device.
Changes:
V5:
* Make sure fbnic_pldm_match_record() always returns a bool
V4 - https://lore.kernel.org/netdev/20250510002851.3247880-1-lee@trager.us/T/#t
* Tested flashing in a 50x loop
* Add devl_lock() in shutdown / quiescene paths like suspend to prevent
interrupting the FW flashing process.
* Add support for multiple completion messages.
* Removed BSD function notation from fbnic_fw_xmit_fw_start_upgrade()
* Mailbox functions no longer return cmpl_data->result
* Add missing error check in fbnic_fw_xmit_fw_write
* Drop setting cmpl->u.fw_update.* to 0
* Set offset and length before validation
* Drop !fw check
* Firmware upgrades are now process driven
* Fix potential memory leak when an error is received in the mailbox when
updating.
* Include anti-rollback support
* Drop retries when updating but increase timeout to 10s
* Use NL_SET_ERR_MSG_FMT_MOD in fbnic_devlink_flash_update()
* Updated cover letter, commit messages, and docs as suggested
* Dropped kdocs
* Patched libpldmfw to not require send_package_data or send_component_table
which allowed stub functions to be dropped.
* Dropped all dev_*() printks
* Fixed Xmas tree variable declarations
V3 - https://lore.kernel.org/lkml/20241111043058.1251632-1-lee@trager.us/T/
* Fix comments
V2 - https://lore.kernel.org/all/20241022013941.3764567-1-lee@trager.us/
* Fixed reversed Xmas tree variable declarations
* Replaced memcpy with strscpy
Lee Trager (5):
pldmfw: Don't require send_package_data or send_component_table to be
defined
eth: fbnic: Accept minimum anti-rollback version from firmware
eth: fbnic: Add support for multiple concurrent completion messages
eth: fbnic: Add mailbox support for PLDM updates
eth: fbnic: Add devlink dev flash support
.../device_drivers/ethernet/meta/fbnic.rst | 11 +
drivers/net/ethernet/meta/Kconfig | 1 +
drivers/net/ethernet/meta/fbnic/fbnic.h | 3 +-
.../net/ethernet/meta/fbnic/fbnic_devlink.c | 260 +++++++++++++++-
drivers/net/ethernet/meta/fbnic/fbnic_fw.c | 294 ++++++++++++++++--
drivers/net/ethernet/meta/fbnic/fbnic_fw.h | 53 +++-
drivers/net/ethernet/meta/fbnic/fbnic_mac.c | 2 +-
drivers/net/ethernet/meta/fbnic/fbnic_pci.c | 9 +
lib/pldmfw/pldmfw.c | 6 +
9 files changed, 616 insertions(+), 23 deletions(-)
--
2.47.1
next reply other threads:[~2025-05-12 19:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 18:53 Lee Trager [this message]
2025-05-12 18:53 ` [PATCH net-next v5 1/5] pldmfw: Don't require send_package_data or send_component_table to be defined Lee Trager
2025-05-12 19:08 ` Jacob Keller
2025-05-12 18:53 ` [PATCH net-next v5 2/5] eth: fbnic: Accept minimum anti-rollback version from firmware Lee Trager
2025-05-12 18:53 ` [PATCH net-next v5 3/5] eth: fbnic: Add support for multiple concurrent completion messages Lee Trager
2025-05-12 19:08 ` Jacob Keller
2025-05-12 18:54 ` [PATCH net-next v5 4/5] eth: fbnic: Add mailbox support for PLDM updates Lee Trager
2025-05-12 18:54 ` [PATCH net-next v5 5/5] eth: fbnic: Add devlink dev flash support Lee Trager
2025-05-12 19:13 ` Jacob Keller
2025-05-13 13:45 ` Simon Horman
2025-05-15 10:58 ` Paolo Abeni
2025-05-15 11:54 ` [PATCH net-next v5 0/5] " Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512190109.2475614-1-lee@trager.us \
--to=lee@trager.us \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanman.p211993@gmail.com \
--cc=suhui@nfschina.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®