From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] tracing: ring_buffer: Rewind persistent ring buffer when reboot
Date: Wed, 14 May 2025 13:33:27 +0900 [thread overview]
Message-ID: <20250514133327.3a6382e5aa0e9d5533fe690c@kernel.org> (raw)
In-Reply-To: <20250513203647.524b1331@gandalf.local.home>
On Tue, 13 May 2025 20:36:47 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 13 May 2025 20:32:37 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > @@ -9628,6 +9636,14 @@ static void setup_trace_scratch(struct trace_array *tr,
> >
> > /* Scan modules to make text delta for modules. */
> > module_for_each_mod(make_mod_delta, tr);
> > +
> > + /* Set trace_clock as the same of the previous boot. */
> > + if (tscratch->clock_id != tr->clock_id) {
> > + if (tracing_set_clock(tr, trace_clocks[tscratch->clock_id].name) < 0) {
> > + pr_info("the previous trace_clock info is not valid.");
> > + goto reset;
> > + }
> > + }
> > return;
> > reset:
> > /* Invalid trace modules */
>
>
> Hmm, somehow I got your other patch in here :-D
Oops, good catch! I mixed other patch there :-(
>
> -- Steve
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2025-05-14 4:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 0:50 Masami Hiramatsu (Google)
2025-05-14 0:32 ` Steven Rostedt
2025-05-14 0:36 ` Steven Rostedt
2025-05-14 4:33 ` Masami Hiramatsu [this message]
2025-05-14 6:00 ` Masami Hiramatsu
2025-05-14 13:00 ` Steven Rostedt
2025-05-15 0:42 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514133327.3a6382e5aa0e9d5533fe690c@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®