From: Lee Jones <lee@kernel.org>
To: lee@kernel.org, bettyzhou@google.com, ynaffit@google.com,
tkjos@google.com, jacek.anaszewski@gmail.com,
Pavel Machek <pavel@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/5] leds: led-test: Provide test for registration with a name that is too long
Date: Wed, 14 May 2025 17:27:55 +0100 [thread overview]
Message-ID: <20250514162807.708010-4-lee@kernel.org> (raw)
In-Reply-To: <20250514162807.708010-1-lee@kernel.org>
Insist on legacy (non-DT) registration and provide a default_label and
devicename that when concatenated together results in a device name that
is unacceptably long.
Signed-off-by: Lee Jones <lee@kernel.org>
---
drivers/leds/led-test.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c
index 3d71c7a23e21..741dc0269515 100644
--- a/drivers/leds/led-test.c
+++ b/drivers/leds/led-test.c
@@ -123,11 +123,28 @@ static void led_test_class_init_data_missing_devicename(struct kunit *test)
KUNIT_EXPECT_EQ(test, ret, -EINVAL);
}
+static void led_test_class_init_data_name_too_long(struct kunit *test)
+{
+ struct led_test_ddata *ddata = test->priv;
+ struct led_classdev *cdev = &ddata->cdev;
+ struct device *dev = ddata->dev;
+ int ret;
+
+ struct led_init_data init_data = {
+ .devicename = "led-test-devicename-very-long-names-fail",
+ .default_label = "led-test-label-also-very-long-names-fail",
+ };
+
+ ret = led_classdev_register_ext(dev, cdev, &init_data);
+ KUNIT_EXPECT_EQ(test, ret, -E2BIG);
+}
+
static struct kunit_case led_test_cases[] = {
KUNIT_CASE(led_test_class_register),
KUNIT_CASE(led_test_class_add_lookup_and_get),
KUNIT_CASE(led_test_class_init_data_missing_default_label),
KUNIT_CASE(led_test_class_init_data_missing_devicename),
+ KUNIT_CASE(led_test_class_init_data_name_too_long),
{ }
};
--
2.49.0.1045.g170613ef41-goog
next prev parent reply other threads:[~2025-05-14 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 16:27 [PATCH 1/5] leds: led-test: Move common LED class registration code into helper function Lee Jones
2025-05-14 16:27 ` [PATCH 2/5] leds: led-test: Provide test for registration with missing default_label Lee Jones
2025-05-14 16:27 ` [PATCH 3/5] leds: led-test: Provide test for registration with missing devicename Lee Jones
2025-05-14 16:27 ` Lee Jones [this message]
2025-05-14 16:27 ` [PATCH 5/5] leds: led-test: Provide test for successful registration using init_data Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514162807.708010-4-lee@kernel.org \
--to=lee@kernel.org \
--cc=bettyzhou@google.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=tkjos@google.com \
--cc=ynaffit@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®