From: Jakub Kicinski <kuba@kernel.org>
To: Ronak Doshi <ronak.doshi@broadcom.com>
Cc: netdev@vger.kernel.org, Guolin Yang <guolin.yang@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Ronghua Zhang <ronghua@vmware.com>,
Bhavesh Davda <bhavesh@vmware.com>,
Shreyas Bhatewara <sbhatewara@vmware.com>,
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH net] vmxnet3: update MTU after device quiesce
Date: Thu, 15 May 2025 06:54:44 -0700 [thread overview]
Message-ID: <20250515065444.60df21c0@kernel.org> (raw)
In-Reply-To: <20250513210243.1828-1-ronak.doshi@broadcom.com>
On Tue, 13 May 2025 21:02:40 +0000 Ronak Doshi wrote:
> @@ -3619,6 +3617,7 @@ vmxnet3_change_mtu(struct net_device *netdev, int new_mtu)
> if (netif_running(netdev)) {
> vmxnet3_quiesce_dev(adapter);
> vmxnet3_reset_dev(adapter);
> + WRITE_ONCE(netdev->mtu, new_mtu);
>
> /* we need to re-create the rx queue based on the new mtu */
> vmxnet3_rq_destroy_all(adapter);
Maybe a nit pick but wouldn't it make the most sense to place the write
after all teardown related code? So after vmxnet3_rq_destroy_all() ?
prev parent reply other threads:[~2025-05-15 13:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 21:02 Ronak Doshi
2025-05-15 13:54 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515065444.60df21c0@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhavesh@vmware.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guolin.yang@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ronak.doshi@broadcom.com \
--cc=ronghua@vmware.com \
--cc=sbhatewara@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®