From: Larysa Zaremba <larysa.zaremba@intel.com>
To: intel-wired-lan@lists.osuosl.org,
Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Jiri Pirko <jiri@resnulli.us>,
Tatyana Nikolova <tatyana.e.nikolova@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Lee Trager <lee@trager.us>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Larysa Zaremba <larysa.zaremba@intel.com>,
Sridhar Samudrala <sridhar.samudrala@intel.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
Ahmed Zaki <ahmed.zaki@intel.com>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, "Karlsson,
Magnus" <magnus.karlsson@intel.com>,
Emil Tantilov <emil.s.tantilov@intel.com>,
Madhu Chittim <madhu.chittim@intel.com>,
Josh Hay <joshua.a.hay@intel.com>,
Milena Olech <milena.olech@intel.com>,
pavan.kumar.linga@intel.com, "Singhai,
Anjali" <anjali.singhai@intel.com>
Subject: [PATCH iwl-next v4 04/15] libeth: allow to create fill queues without NAPI
Date: Fri, 16 May 2025 16:58:01 +0200 [thread overview]
Message-ID: <20250516145814.5422-5-larysa.zaremba@intel.com> (raw)
In-Reply-To: <20250516145814.5422-1-larysa.zaremba@intel.com>
From: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
Control queues can utilize libeth_rx fill queues, despite working outside
of NAPI context. The only problem is standard fill queues requiring NAPI
that provides them with the device pointer.
Introduce a way to provide the device directly without using NAPI.
Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
---
drivers/net/ethernet/intel/libeth/rx.c | 9 +++++----
include/net/libeth/rx.h | 4 +++-
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/libeth/rx.c b/drivers/net/ethernet/intel/libeth/rx.c
index c0be9cb043a1..b077454c4100 100644
--- a/drivers/net/ethernet/intel/libeth/rx.c
+++ b/drivers/net/ethernet/intel/libeth/rx.c
@@ -143,19 +143,20 @@ static bool libeth_rx_page_pool_params_zc(struct libeth_fq *fq,
/**
* libeth_rx_fq_create - create a PP with the default libeth settings
* @fq: buffer queue struct to fill
- * @napi: &napi_struct covering this PP (no usage outside its poll loops)
+ * @napi_dev: &napi_struct for NAPI (data) queues, &device for others
*
* Return: %0 on success, -%errno on failure.
*/
-int libeth_rx_fq_create(struct libeth_fq *fq, struct napi_struct *napi)
+int libeth_rx_fq_create(struct libeth_fq *fq, void *napi_dev)
{
+ struct napi_struct *napi = fq->no_napi ? NULL : napi_dev;
struct page_pool_params pp = {
.flags = PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV,
.order = LIBETH_RX_PAGE_ORDER,
.pool_size = fq->count,
.nid = fq->nid,
- .dev = napi->dev->dev.parent,
- .netdev = napi->dev,
+ .dev = napi ? napi->dev->dev.parent : napi_dev,
+ .netdev = napi ? napi->dev : NULL,
.napi = napi,
};
struct libeth_fqe *fqes;
diff --git a/include/net/libeth/rx.h b/include/net/libeth/rx.h
index 5d991404845e..0e736846c5e8 100644
--- a/include/net/libeth/rx.h
+++ b/include/net/libeth/rx.h
@@ -69,6 +69,7 @@ enum libeth_fqe_type {
* @type: type of the buffers this queue has
* @hsplit: flag whether header split is enabled
* @xdp: flag indicating whether XDP is enabled
+ * @no_napi: the queue is not a data queue and does not have NAPI
* @buf_len: HW-writeable length per each buffer
* @nid: ID of the closest NUMA node with memory
*/
@@ -85,12 +86,13 @@ struct libeth_fq {
enum libeth_fqe_type type:2;
bool hsplit:1;
bool xdp:1;
+ bool no_napi:1;
u32 buf_len;
int nid;
};
-int libeth_rx_fq_create(struct libeth_fq *fq, struct napi_struct *napi);
+int libeth_rx_fq_create(struct libeth_fq *fq, void *napi_dev);
void libeth_rx_fq_destroy(struct libeth_fq *fq);
/**
--
2.47.0
next prev parent reply other threads:[~2025-05-16 14:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 14:57 [PATCH iwl-next v4 00/15] Introduce iXD driver Larysa Zaremba
2025-05-16 14:57 ` [PATCH iwl-next v4 01/15] virtchnl: create 'include/linux/intel' and move necessary header files Larysa Zaremba
2025-05-16 14:57 ` [PATCH iwl-next v4 02/15] virtchnl: introduce control plane version fields Larysa Zaremba
2025-05-16 14:58 ` [PATCH iwl-next v4 03/15] libie: add PCI device initialization helpers to libie Larysa Zaremba
2025-05-16 14:58 ` Larysa Zaremba [this message]
2025-05-16 14:58 ` [PATCH iwl-next v4 05/15] libie: add control queue support Larysa Zaremba
2025-05-16 14:58 ` [PATCH iwl-next v4 06/15] libie: add bookkeeping support for control queue messages Larysa Zaremba
2025-05-16 14:58 ` [PATCH iwl-next v4 07/15] idpf: remove 'vport_params_reqd' field Larysa Zaremba
2025-06-10 21:50 ` [Intel-wired-lan] " Salin, Samuel
2025-05-16 14:58 ` [PATCH iwl-next v4 08/15] idpf: refactor idpf to use libie_pci APIs Larysa Zaremba
2025-06-10 21:51 ` [Intel-wired-lan] " Salin, Samuel
2025-05-16 14:58 ` [PATCH iwl-next v4 09/15] idpf: refactor idpf to use libie control queues Larysa Zaremba
2025-06-10 21:51 ` [Intel-wired-lan] " Salin, Samuel
2025-06-18 0:04 ` Tantilov, Emil S
2025-06-18 7:54 ` Larysa Zaremba
2025-06-19 2:57 ` Tantilov, Emil S
2025-05-16 14:58 ` [PATCH iwl-next v4 10/15] idpf: make mbx_task queueing and cancelling more consistent Larysa Zaremba
2025-06-10 21:51 ` [Intel-wired-lan] " Salin, Samuel
2025-05-16 14:58 ` [PATCH iwl-next v4 11/15] idpf: print a debug message and bail in case of non-event ctlq message Larysa Zaremba
2025-06-10 21:53 ` [Intel-wired-lan] " Salin, Samuel
2025-05-16 14:58 ` [PATCH iwl-next v4 12/15] ixd: add basic driver framework for Intel(R) Control Plane Function Larysa Zaremba
2025-05-16 14:58 ` [PATCH iwl-next v4 13/15] ixd: add reset checks and initialize the mailbox Larysa Zaremba
2025-05-16 14:58 ` [PATCH iwl-next v4 14/15] ixd: add the core initialization Larysa Zaremba
2025-05-16 14:58 ` [PATCH iwl-next v4 15/15] ixd: add devlink support Larysa Zaremba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250516145814.5422-5-larysa.zaremba@intel.com \
--to=larysa.zaremba@intel.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anjali.singhai@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=emil.s.tantilov@intel.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=joshua.a.hay@intel.com \
--cc=kuba@kernel.org \
--cc=lee@trager.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=maddy@linux.ibm.com \
--cc=madhu.chittim@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=mateusz.polchlopek@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=milena.olech@intel.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.kumar.linga@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=tatyana.e.nikolova@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®