From: Kurt Borja <kuurtb@gmail.com>
To: "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Joshua Grisham" <josh@joshuagrisham.com>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Armin Wolf" <W_Armin@gmx.de>,
"Mario Limonciello" <mario.limonciello@amd.com>
Cc: Antheas Kapenekakis <lkml@antheas.dev>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
Prasanth Ksr <prasanth.ksr@dell.com>,
Jorge Lopez <jorge.lopez2@hp.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com,
Kurt Borja <kuurtb@gmail.com>
Subject: [PATCH v2 0/5] platform/x86: firmware_attributes_class: Add a high level API
Date: Sat, 17 May 2025 05:51:35 -0300 [thread overview]
Message-ID: <20250517-fw-attrs-api-v2-0-fa1ab045a01c@gmail.com> (raw)
Hi all,
These series adds the _long awaited_ API for the Firmware Attributes
class.
You'll find all the details in the commit messages and kernel-doc.
I think it's easier to understand by example, so I used the
samsung-galaxybook driver for this purpose (last patch). IMO code
readibility, simplicity, maintainability, etc. is greatly improved, but
there is still room for improvement of the API itself. For this reason I
submitted this as an RFC.
As always, your feedback is very appreciated :)
Overview
========
Patch 1-2: New API with docs included.
Patch 3: New firwmare attributes type
Patch 4: Misc Maintainers patch
Patch 5: samsung-galaxybook example
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
Changes in v2:
[Patch 1]
- Include kdev_t.h header
[Patch 2]
- Use one line comments in fwat_create_attrs()
- Check propagate errors in fwat_create_attrs()
- Add `mode` to fwat_attr_config and related macros to let users
configure the `current_value` attribute mode
- Use defined structs in fwat_attr_ops instead of anonymous ones
- Move fwat_attr_type from config to ops
[Patch 5]
- Just transition to new API without chaing ABI
- Link to v1: https://lore.kernel.org/r/20250509-fw-attrs-api-v1-0-258afed65bfa@gmail.com
---
Kurt Borja (4):
platform/x86: firmware_attributes_class: Add a high level API
platform/x86: firmware_attributes_class: Add a boolean type
MAINTAINERS: Add FIRMWARE ATTRIBUTES CLASS entry
platform/x86: samsung-galaxybook: Transition to new firmware_attributes API
Thomas Weißschuh (1):
platform/x86: firmware_attributes_class: Add device initialization methods
.../ABI/testing/sysfs-class-firmware-attributes | 1 +
MAINTAINERS | 7 +
drivers/platform/x86/firmware_attributes_class.c | 454 +++++++++++++++++++++
drivers/platform/x86/firmware_attributes_class.h | 276 +++++++++++++
drivers/platform/x86/samsung-galaxybook.c | 308 ++++++--------
5 files changed, 861 insertions(+), 185 deletions(-)
---
base-commit: 9f080c9f2099b5a81c85b3b7f95fd11fad428cc8
change-id: 20250326-fw-attrs-api-0eea7c0225b6
--
~ Kurt
next reply other threads:[~2025-05-17 8:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-17 8:51 Kurt Borja [this message]
2025-05-17 8:51 ` [PATCH v2 1/5] platform/x86: firmware_attributes_class: Add device initialization methods Kurt Borja
2025-05-17 8:51 ` [PATCH v2 2/5] platform/x86: firmware_attributes_class: Add a high level API Kurt Borja
2025-05-17 8:51 ` [PATCH v2 3/5] platform/x86: firmware_attributes_class: Add a boolean type Kurt Borja
2025-05-17 8:51 ` [PATCH v2 4/5] MAINTAINERS: Add FIRMWARE ATTRIBUTES CLASS entry Kurt Borja
2025-05-17 8:51 ` [PATCH v2 5/5] platform/x86: samsung-galaxybook: Transition to new firmware_attributes API Kurt Borja
2025-06-07 16:38 ` [PATCH v2 0/5] platform/x86: firmware_attributes_class: Add a high level API Joshua Grisham
2025-06-09 1:30 ` Kurt Borja
2025-06-09 9:29 ` Ilpo Järvinen
2025-06-09 19:03 ` Kurt Borja
2025-06-09 13:03 ` Joshua Grisham
2025-06-09 19:00 ` Kurt Borja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250517-fw-attrs-api-v2-0-fa1ab045a01c@gmail.com \
--to=kuurtb@gmail.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=W_Armin@gmx.de \
--cc=derekjohn.clark@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jorge.lopez2@hp.com \
--cc=josh@joshuagrisham.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=lkml@antheas.dev \
--cc=mario.limonciello@amd.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=prasanth.ksr@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®