From: Jonathan Cameron <jic23@kernel.org>
To: Waqar Hameed <waqar.hameed@axis.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>, <kernel@axis.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] iio: irsd200: Remove print of error code from dev_err_probe
Date: Sun, 18 May 2025 17:07:12 +0100 [thread overview]
Message-ID: <20250518170712.7005d494@jic23-huawei> (raw)
In-Reply-To: <83c5ed21654b1b98437247d0fef823237af641b4.1747415559.git.waqar.hameed@axis.com>
On Fri, 16 May 2025 19:18:56 +0200
Waqar Hameed <waqar.hameed@axis.com> wrote:
> Since `dev_err_probe()` already prints the error code, there is no need
> to additionally print it in the error message. Therefore, just remove
> them.
>
> Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
Applied. Thanks.
Note that I'm now queuing stuff up for 6.17 unless the 6.15 release is
delayed for some reason. That means I'll only push out as testing and
will be rebasing on 6.16-rc1
Jonathan
> ---
> drivers/iio/proximity/irsd200.c | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/iio/proximity/irsd200.c b/drivers/iio/proximity/irsd200.c
> index b0ffd3574013..011b506f4542 100644
> --- a/drivers/iio/proximity/irsd200.c
> +++ b/drivers/iio/proximity/irsd200.c
> @@ -881,9 +881,8 @@ static int irsd200_probe(struct i2c_client *client)
>
> ret = devm_regulator_get_enable(data->dev, "vdd");
> if (ret)
> - return dev_err_probe(
> - data->dev, ret,
> - "Could not get and enable regulator (%d)\n", ret);
> + return dev_err_probe(data->dev, ret,
> + "Could not get and enable regulator\n");
>
> ret = irsd200_setup(data);
> if (ret)
> @@ -901,17 +900,15 @@ static int irsd200_probe(struct i2c_client *client)
> ret = devm_iio_triggered_buffer_setup(data->dev, indio_dev, NULL,
> irsd200_trigger_handler, NULL);
> if (ret)
> - return dev_err_probe(
> - data->dev, ret,
> - "Could not setup iio triggered buffer (%d)\n", ret);
> + return dev_err_probe(data->dev, ret,
> + "Could not setup iio triggered buffer\n");
>
> ret = devm_request_threaded_irq(data->dev, client->irq, NULL,
> irsd200_irq_thread,
> IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> NULL, indio_dev);
> if (ret)
> - return dev_err_probe(data->dev, ret,
> - "Could not request irq (%d)\n", ret);
> + return dev_err_probe(data->dev, ret, "Could not request irq\n");
>
> trigger = devm_iio_trigger_alloc(data->dev, "%s-dev%d", indio_dev->name,
> iio_device_id(indio_dev));
> @@ -925,14 +922,12 @@ static int irsd200_probe(struct i2c_client *client)
> ret = devm_iio_trigger_register(data->dev, trigger);
> if (ret)
> return dev_err_probe(data->dev, ret,
> - "Could not register iio trigger (%d)\n",
> - ret);
> + "Could not register iio trigger\n");
>
> ret = devm_iio_device_register(data->dev, indio_dev);
> if (ret)
> return dev_err_probe(data->dev, ret,
> - "Could not register iio device (%d)\n",
> - ret);
> + "Could not register iio device\n");
>
> return 0;
> }
>
> base-commit: d76bb1ebb5587f66b0f8b8099bfbb44722bc08b3
prev parent reply other threads:[~2025-05-18 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 17:18 Waqar Hameed
2025-05-18 16:07 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250518170712.7005d494@jic23-huawei \
--to=jic23@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel@axis.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®