From: Ian Rogers <irogers@google.com>
To: Gautam Menghani <gautam@linux.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Howard Chu <howardchu95@gmail.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Cc: maddy@linux.ibm.com
Subject: [PATCH v3 1/7] libperf threadmap: Don't segv for index 0 for the NULL perf_thread_map
Date: Mon, 19 May 2025 12:51:38 -0700 [thread overview]
Message-ID: <20250519195148.1708988-2-irogers@google.com> (raw)
In-Reply-To: <20250519195148.1708988-1-irogers@google.com>
perf_thread_map__nr returns length 1 if the perf_thread_map is NULL,
meaning index 0 is valid. When perf_thread_map__pid of index 0 is read
then return the expected "any" -1 value. Assert this is only done for
index 0.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/lib/perf/threadmap.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tools/lib/perf/threadmap.c b/tools/lib/perf/threadmap.c
index 07968f3ea093..3ca9ba4987fc 100644
--- a/tools/lib/perf/threadmap.c
+++ b/tools/lib/perf/threadmap.c
@@ -97,5 +97,10 @@ int perf_thread_map__nr(struct perf_thread_map *threads)
pid_t perf_thread_map__pid(struct perf_thread_map *map, int idx)
{
+ if (!map) {
+ assert(idx == 0);
+ return -1;
+ }
+
return map->map[idx].pid;
}
--
2.49.0.1101.gccaa498523-goog
next prev parent reply other threads:[~2025-05-19 19:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 19:51 [PATCH v3 0/7] perf python: Add missing infra pieces for counting Ian Rogers
2025-05-19 19:51 ` Ian Rogers [this message]
2025-05-19 19:51 ` [PATCH v3 2/7] libperf threadmap: Add perf_thread_map__idx Ian Rogers
2025-05-19 19:51 ` [PATCH v3 3/7] perf python: Add evsel cpus and threads functions Ian Rogers
2025-05-19 19:51 ` [PATCH v3 4/7] perf python: Add support for perf_counts_values to return counter data Ian Rogers
2025-05-21 13:20 ` Arnaldo Carvalho de Melo
2025-05-21 13:56 ` Ian Rogers
2025-05-21 17:26 ` Arnaldo Carvalho de Melo
2025-05-22 22:20 ` Arnaldo Carvalho de Melo
2025-05-22 22:32 ` Ian Rogers
2025-05-22 22:36 ` Arnaldo Carvalho de Melo
2025-05-22 22:37 ` Arnaldo Carvalho de Melo
2025-05-23 1:28 ` Arnaldo Carvalho de Melo
2025-05-26 14:49 ` Gautam Menghani
2025-05-19 19:51 ` [PATCH v3 5/7] perf python: Add evsel read method Ian Rogers
2025-05-21 13:18 ` Arnaldo Carvalho de Melo
2025-05-19 19:51 ` [PATCH v3 6/7] perf python: Add evlist close support Ian Rogers
2025-05-19 19:51 ` [PATCH v3 7/7] perf python: Add counting.py as example for counting perf events Ian Rogers
2025-05-21 14:46 ` Arnaldo Carvalho de Melo
2025-05-21 12:27 ` [PATCH v3 0/7] perf python: Add missing infra pieces for counting Gautam Menghani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250519195148.1708988-2-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=gautam@linux.ibm.com \
--cc=howardchu95@gmail.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®